From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47252)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b3669-0004Fz-OJ
	for qemu-devel@nongnu.org; Wed, 18 May 2016 14:21:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b3666-0003Gu-Hi
	for qemu-devel@nongnu.org; Wed, 18 May 2016 14:21:33 -0400
Received: from mail-lb0-x243.google.com ([2a00:1450:4010:c04::243]:34040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1b3666-0003Gd-9h
	for qemu-devel@nongnu.org; Wed, 18 May 2016 14:21:30 -0400
Received: by mail-lb0-x243.google.com with SMTP id bg8so3191955lbc.1
	for <qemu-devel@nongnu.org>; Wed, 18 May 2016 11:21:30 -0700 (PDT)
References: <1463196873-17737-1-git-send-email-cota@braap.org>
	<1463196873-17737-8-git-send-email-cota@braap.org>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <573CB2A6.6070704@gmail.com>
Date: Wed, 18 May 2016 21:21:26 +0300
MIME-Version: 1.0
In-Reply-To: <1463196873-17737-8-git-send-email-cota@braap.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 07/18] qemu-thread: add simple
 test-and-set spinlock
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@listserver.greensocs.com>
Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Richard Henderson <rth@twiddle.net>

On 14/05/16 06:34, Emilio G. Cota wrote:
> +static inline int qemu_spin_trylock(QemuSpin *spin)
> +{
> +    if (atomic_test_and_set_acquire(&spin->value)) {
> +        return -EBUSY;

Seems this should be:

    return EBUSY;

> +    }
> +    return 0;
> +}