From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Exc-0004xq-OX for qemu-devel@nongnu.org; Wed, 18 May 2016 23:49:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3ExX-0001pE-Q0 for qemu-devel@nongnu.org; Wed, 18 May 2016 23:49:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3ExX-0001of-Jh for qemu-devel@nongnu.org; Wed, 18 May 2016 23:49:15 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9EF15C04B321 for ; Thu, 19 May 2016 03:49:14 +0000 (UTC) References: <1463589381-66853-1-git-send-email-pbonzini@redhat.com> <1463589381-66853-5-git-send-email-pbonzini@redhat.com> From: Thomas Huth Message-ID: <573D37B7.8030402@redhat.com> Date: Thu, 19 May 2016 05:49:11 +0200 MIME-Version: 1.0 In-Reply-To: <1463589381-66853-5-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/52] target-ppc: do not make PowerPCCPUClass depend on target-specific symbols List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org On 18.05.2016 18:36, Paolo Bonzini wrote: > Just leave some members in even if they are unused on e.g. > 32-bit PPC or user-mode emulation. This avoids complications > when using PowerPCCPUClass in code that is compiled just > once (because it applies to both 32-bit and 64-bit PPC > for example) but still needs to peek at PPC-specific members. > > Signed-off-by: Paolo Bonzini > --- > target-ppc/cpu-qom.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/target-ppc/cpu-qom.h b/target-ppc/cpu-qom.h > index bab501f..6f4e929 100644 > --- a/target-ppc/cpu-qom.h > +++ b/target-ppc/cpu-qom.h > @@ -67,14 +67,10 @@ typedef struct PowerPCCPUClass { > uint32_t flags; > int bfd_mach; > uint32_t l1_dcache_size, l1_icache_size; > -#if defined(TARGET_PPC64) > const struct ppc_segment_page_sizes *sps; > -#endif > void (*init_proc)(CPUPPCState *env); > int (*check_pow)(CPUPPCState *env); > -#if defined(CONFIG_SOFTMMU) > int (*handle_mmu_fault)(PowerPCCPU *cpu, vaddr eaddr, int rwx, int mmu_idx); > -#endif > bool (*interrupts_big_endian)(PowerPCCPU *cpu); > } PowerPCCPUClass; > > Reviewed-by: Thomas Huth