From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3FCf-0001uh-Kz for qemu-devel@nongnu.org; Thu, 19 May 2016 00:04:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3FCc-0005Tf-CK for qemu-devel@nongnu.org; Thu, 19 May 2016 00:04:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3FCc-0005Sh-6O for qemu-devel@nongnu.org; Thu, 19 May 2016 00:04:50 -0400 References: <1463589381-66853-1-git-send-email-pbonzini@redhat.com> From: Thomas Huth Message-ID: <573D3B5D.4040701@redhat.com> Date: Thu, 19 May 2016 06:04:45 +0200 MIME-Version: 1.0 In-Reply-To: <1463589381-66853-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH CFT v4 00/52] NEED_CPU_H / cpu.h / hw/hw.h cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: Cornelia Huck On 18.05.2016 18:36, Paolo Bonzini wrote: > This series removes usage of NEED_CPU_H from several central > include files in QEMU, most notably hw/hw.h and qemu-common.h. > Definitions conditional on NEED_CPU_H remain only in disas/disas.h, > exec/gdbstub.h, exec/helper-head.h and exec/log.h. >=20 > The interesting patches are interspersed with other miscellaenous > cleanups that I won't really dwell on in the cover letter; the main > changes are: >=20 > - make sure that target-independent code can access QOM objects > for the CPU through an opaque type. There still seems to be some target-specific code in some of the cpu-qom.h headers: $ grep -r TARGET_ target-*/cpu-qom.h target-i386/cpu-qom.h:#ifdef TARGET_X86_64 target-mips/cpu-qom.h:#ifdef TARGET_MIPS64 target-ppc/cpu-qom.h:#ifdef TARGET_PPC64 target-ppc/cpu-qom.h:#elif defined(TARGET_PPCEMB) target-ppc/cpu-qom.h:#if defined(TARGET_PPC64) target-ppc/cpu-qom.h:#endif /* defined(TARGET_PPC64) */ target-sparc/cpu-qom.h:#ifdef TARGET_SPARC64 This will mainly affect the *_CPU_CLASS macros ... should these macros now also be moved to target-*/cpu.h instead? [...] > As before, I would appreciate people compile-testing it on PPC. It sho= uld > fix all the problems reported previously. The changes are available in > the git repository at git://github.com/bonzini/qemu.git, branch need-cp= u-h I've just re-checked that branch, and now it compiles fine for me on PPC. Thomas