From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3XAQ-00036t-Lt for qemu-devel@nongnu.org; Thu, 19 May 2016 19:15:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3XAN-00048B-Gk for qemu-devel@nongnu.org; Thu, 19 May 2016 19:15:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3XAN-00047s-8O for qemu-devel@nongnu.org; Thu, 19 May 2016 19:15:43 -0400 References: <1463473231-491-1-git-send-email-den@openvz.org> <1463473231-491-2-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <573E491D.2000009@redhat.com> Date: Thu, 19 May 2016 17:15:41 -0600 MIME-Version: 1.0 In-Reply-To: <1463473231-491-2-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p5xfK481xkgnH92qO1HseikNftxqP7PCE" Subject: Re: [Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/control.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p5xfK481xkgnH92qO1HseikNftxqP7PCE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 02:20 AM, Denis V. Lunev wrote: > The patch also creates trace_opt_parse() helper in trace/control.c to r= euse > this code in next patches for qemu-nbd and qemu-io. >=20 > The patch also makes trace_init_events() static, as this call is not us= ed > outside the module anymore. >=20 > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > trace/control.c | 44 +++++++++++++++++++++++++++++++++++++++++++- > trace/control.h | 24 +++++++++++++----------- > vl.c | 37 +------------------------------------ > 3 files changed, 57 insertions(+), 48 deletions(-) >=20 > =20 > +QemuOptsList qemu_trace_opts =3D { > + .name =3D "trace", > + .implied_opt_name =3D "enable", > + .head =3D QTAILQ_HEAD_INITIALIZER(qemu_trace_opts.head), > + .desc =3D { > + { > + .name =3D "enable", > + .type =3D QEMU_OPT_STRING, > + }, > + { > + .name =3D "events", > + .type =3D QEMU_OPT_STRING, > + },{ I know this is straight code motion, but we aren't very consistent on spacing between elements. Might be worth the extra newline here while touching it? > + .name =3D "file", > + .type =3D QEMU_OPT_STRING, > + }, > + { /* end of list */ } > + }, > +}; Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --p5xfK481xkgnH92qO1HseikNftxqP7PCE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXPkkdAAoJEKeha0olJ0NqyuEH/0Cbc6Nz1YUgLnVn4VILHHP9 vr7zeItsYT4QWCwdxQ2SujQBx+WgxUjAXBUpRA+UTaYES4aZyGPhOxQAif2tlpst /ubzHIdsT4NrvM66htcLLsEB6gMVU/ppTIdaATfaTXtU0QxquKkKpvJCx8/UWGNp eXL4gnVEZ4v5zR8yPKz+wK4NFs1JwEqzPJRSI4/b16rmVnZ0xqwnNUP0LiHT2EyA dsZyzg0kjON2UFuDUx3hNRQ1JH01Yme3OhYLTSJDheGfx1F0FnnBPVqW/SGurGTY ZVTx+AV0JGM5cJfgXiMWU1oHtY6hc26W1sIJTYd3ovd0++zCzzrk/zWuZE4892o= =JObf -----END PGP SIGNATURE----- --p5xfK481xkgnH92qO1HseikNftxqP7PCE--