From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3XIH-0004vc-L7 for qemu-devel@nongnu.org; Thu, 19 May 2016 19:23:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3XIC-0005he-SS for qemu-devel@nongnu.org; Thu, 19 May 2016 19:23:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3XIC-0005hX-Mc for qemu-devel@nongnu.org; Thu, 19 May 2016 19:23:48 -0400 References: <1463473231-491-1-git-send-email-den@openvz.org> <1463473231-491-3-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <573E4B02.1070907@redhat.com> Date: Thu, 19 May 2016 17:23:46 -0600 MIME-Version: 1.0 In-Reply-To: <1463473231-491-3-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CqMRwIjiQ8KCc5j9cJ28egDeMVi1h54Eg" Subject: Re: [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CqMRwIjiQ8KCc5j9cJ28egDeMVi1h54Eg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 02:20 AM, Denis V. Lunev wrote: > Moving trace_init_backends() into trace_opt_parse() is not possible. Th= is > should be called after daemonize() in vl.c. >=20 > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > qemu-io.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) Please add documentation of the new syntax of the -T option, so that it shows up in --help output (I'd ask for it in the man page, too, except qemu-io doesn't seem to have one). With just this patch applied, I still see in 'qemu-io --help': -T, --trace FILE enable trace events listed in the given file which doesn't tell me how to turn on particular trace events, vs. the more useful details in 'qemu-system-x86_64 --help': -trace [[enable=3D]][,events=3D][,file=3D] specify tracing options It is okay to just say "see qemu(1) man page for full description" (the way we did for the --object option), rather than copy-and-paste a paragraph that might go out of sync over time. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CqMRwIjiQ8KCc5j9cJ28egDeMVi1h54Eg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXPksCAAoJEKeha0olJ0NqfVAH/3y0M0jkdtaAGm6OLMXuHBRG 24lcoB7whSxiyCjQmxhvpgIE/Ot4wuTLO7HEfepuprX6opsYQSNZ51krqdR8lm2F oRfYuvRq/zr/mi3r6wO4AYuDgz0xCaKF+vFQ2kXnY/mnOrr7j9OsfGzJxb5VPakX +a4ORhhFnDOQRqEZUmcA3r6Yxqha7H9MYNQpUsgHt4esSiaaa3SRW3bzPIwUKyN0 N13/Z1NBHGUW+UlLj54xolP8yypLMOHYr2V8Q6wNszAFN9ttAkLYSuUzoPfcPSUq dKB2HfXfkEo/3LqmRgcufTD89Wi6habGl6raI2gfrsBUikxUfW8D3cZ29AlLmkA= =9u7j -----END PGP SIGNATURE----- --CqMRwIjiQ8KCc5j9cJ28egDeMVi1h54Eg--