From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3XKZ-0006Ah-LJ for qemu-devel@nongnu.org; Thu, 19 May 2016 19:26:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3XKU-0006Mr-8P for qemu-devel@nongnu.org; Thu, 19 May 2016 19:26:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3XKU-0006Mk-2H for qemu-devel@nongnu.org; Thu, 19 May 2016 19:26:10 -0400 References: <1463473231-491-1-git-send-email-den@openvz.org> <1463473231-491-4-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <573E4B90.7090702@redhat.com> Date: Thu, 19 May 2016 17:26:08 -0600 MIME-Version: 1.0 In-Reply-To: <1463473231-491-4-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j1i5vP6Fe7i58LMnlgtMATIb3GqPQNIm9" Subject: Re: [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j1i5vP6Fe7i58LMnlgtMATIb3GqPQNIm9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/17/2016 02:20 AM, Denis V. Lunev wrote: > Pls note, trace_init_backends() must be called in the final process, i.= e. s/Pls/Please/ > after daemonization. This is necessary to keep tracing thread in the > proper process. >=20 > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > qemu-nbd.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) Same comments as on 2/3 - missing documentation - this time, it is the man page that is incomplete. > @@ -87,6 +89,7 @@ static void usage(const char *name) > "General purpose options:\n" > " --object type,id=3DID,... define an object such as 'secret' for p= roviding\n" > " passwords and/or encryption keys\n" > +" -T, --trace FILE enable trace events listed in the given f= ile\n" Insufficient, compared to how qemu's help text reads. But overall a cool concept. Are there any plans to convert some of the TRACE() debugging printfs in nbd/* into actual trace points? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --j1i5vP6Fe7i58LMnlgtMATIb3GqPQNIm9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXPkuQAAoJEKeha0olJ0NqQ4sH/1DtTfSMIeSbTtpJ7R8fodDu hHVf8Shdwi9Wpd0Dd4V52/Nc5wAlDnYW/+Xv07MAVnaPYSjUw8X5RjdO2cQFsujA AxsJOqvxvJPGFJRFza77grPPWmHPjKIDHrHntO3DK3wVzs12TrW8QqlRYHQukMCc XVp89r3/2Jk2tj2CmaTFYrQbWSgNJi/020IhzzPCT/IacHv+TH7XyUsFQB79SOsW UOFZejEBrE6vf+3hvrWalAadrLVVvJ+ilwnaLokQhkIGqMUKsL8WS8RM60nty/70 HxlBjIKs0YDFwi1kBHfGaqbI02jlQ19nw4BfOw700HRB1QgpZ6Ob4DhBhjtHMiY= =iYSh -----END PGP SIGNATURE----- --j1i5vP6Fe7i58LMnlgtMATIb3GqPQNIm9--