From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Maksim Davydov <davydov-max@yandex-team.ru>, qemu-devel@nongnu.org
Cc: vsementsov@yandex-team.ru, eduardo@habkost.net,
marcel.apfelbaum@gmail.com, wangyanan55@huawei.com,
jsnow@redhat.com, crosa@redhat.com, bleal@redhat.com,
eblake@redhat.com, armbru@redhat.com, pbonzini@redhat.com,
berrange@redhat.com, alxndr@bu.edu, bsd@redhat.com,
stefanha@redhat.com, thuth@redhat.com, darren.kenny@oracle.com,
Qiuhao.Li@outlook.com, lvivier@redhat.com
Subject: Re: [PATCH v6 3/4] python: add binary
Date: Wed, 8 Nov 2023 18:57:52 +0100 [thread overview]
Message-ID: <573b7776-a01d-4837-a17c-059ed8159b57@linaro.org> (raw)
In-Reply-To: <20231108153827.39692-4-davydov-max@yandex-team.ru>
Hi Maksim,
On 8/11/23 16:38, Maksim Davydov wrote:
> Add a supportive property to access the path to the qemu binary
>
> Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru>
> ---
> python/qemu/machine/machine.py | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
> index 31cb9d617d..78436403b2 100644
> --- a/python/qemu/machine/machine.py
> +++ b/python/qemu/machine/machine.py
> @@ -328,6 +328,11 @@ def args(self) -> List[str]:
> """Returns the list of arguments given to the QEMU binary."""
> return self._args
>
> + @property
> + def binary(self) -> str:
> + """Returns path to the qemu binary"""
s/qemu/QEMU/ (like 2 lines earlier).
Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> + return self._binary
> +
> def _pre_launch(self) -> None:
> if self._qmp_set:
> if self._monitor_address is None:
next prev parent reply other threads:[~2023-11-08 17:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:38 [PATCH v6 0/4] compare machine type compat_props Maksim Davydov
2023-11-08 15:38 ` [PATCH v6 1/4] qom: add default value Maksim Davydov
2023-11-08 17:58 ` Philippe Mathieu-Daudé
2023-12-01 9:30 ` Markus Armbruster
2023-11-08 15:38 ` [PATCH v6 2/4] qmp: add dump machine type compatible properties Maksim Davydov
2023-12-01 9:49 ` Markus Armbruster
2023-12-13 14:46 ` Maksim Davydov
2023-12-18 13:18 ` Markus Armbruster
2023-11-08 15:38 ` [PATCH v6 3/4] python: add binary Maksim Davydov
2023-11-08 17:57 ` Philippe Mathieu-Daudé [this message]
2023-11-09 21:49 ` John Snow
2023-11-10 7:03 ` Philippe Mathieu-Daudé
2023-11-14 10:54 ` Maksim Davydov
2023-11-08 15:38 ` [PATCH v6 4/4] scripts: add script to compare compatible properties Maksim Davydov
2023-12-01 9:51 ` Markus Armbruster
2023-12-13 14:48 ` Maksim Davydov
2023-12-18 13:19 ` Markus Armbruster
2024-01-08 23:43 ` John Snow
2023-12-01 11:04 ` [PATCH v6 0/4] compare machine type compat_props Philippe Mathieu-Daudé
2023-12-01 13:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573b7776-a01d-4837-a17c-059ed8159b57@linaro.org \
--to=philmd@linaro.org \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=bsd@redhat.com \
--cc=crosa@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=davydov-max@yandex-team.ru \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).