From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b49yl-0004yh-NE for qemu-devel@nongnu.org; Sat, 21 May 2016 12:42:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b49yh-0007w1-Dz for qemu-devel@nongnu.org; Sat, 21 May 2016 12:42:18 -0400 Received: from mout.web.de ([212.227.15.14]:56266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b49yh-0007vl-3J for qemu-devel@nongnu.org; Sat, 21 May 2016 12:42:15 -0400 References: <1463847590-22782-1-git-send-email-bd.aviv@gmail.com> <1463847590-22782-2-git-send-email-bd.aviv@gmail.com> From: Jan Kiszka Message-ID: <57408FDB.1010000@web.de> Date: Sat, 21 May 2016 18:42:03 +0200 MIME-Version: 1.0 In-Reply-To: <1463847590-22782-2-git-send-email-bd.aviv@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pL1wNRgEmphrqHhLFOimAP8k11UqDoUHu" Subject: Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aviv B.D" , qemu-devel@nongnu.org Cc: Alex Williamson , Peter Xu , "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pL1wNRgEmphrqHhLFOimAP8k11UqDoUHu From: Jan Kiszka To: "Aviv B.D" , qemu-devel@nongnu.org Cc: Alex Williamson , Peter Xu , "Michael S. Tsirkin" Message-ID: <57408FDB.1010000@web.de> Subject: Re: [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest References: <1463847590-22782-1-git-send-email-bd.aviv@gmail.com> <1463847590-22782-2-git-send-email-bd.aviv@gmail.com> In-Reply-To: <1463847590-22782-2-git-send-email-bd.aviv@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 2016-05-21 18:19, Aviv B.D wrote: > From: "Aviv Ben-David" >=20 > This flag tells the guest to invalidate tlb cache also after unmap oper= ations. >=20 > Signed-off-by: Aviv Ben-David > --- > hw/i386/intel_iommu.c | 3 ++- > hw/i386/intel_iommu_internal.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 347718f..1af8da8 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -1949,7 +1949,8 @@ static void vtd_init(IntelIOMMUState *s) > s->iq_last_desc_type =3D VTD_INV_DESC_NONE; > s->next_frcd_reg =3D 0; > s->cap =3D VTD_CAP_FRO | VTD_CAP_NFR | VTD_CAP_ND | VTD_CAP_MGAW |= > - VTD_CAP_SAGAW | VTD_CAP_MAMV | VTD_CAP_PSI | VTD_CAP_SLLP= S; > + VTD_CAP_SAGAW | VTD_CAP_MAMV | VTD_CAP_PSI | VTD_CAP_SLLP= S | > + VTD_CAP_CM; Again, needs to be optional because not all guests will support it or behave differently when it's set (I've one that refuses to work). Jan > s->ecap =3D VTD_ECAP_QI | VTD_ECAP_IRO; > =20 > vtd_reset_context_cache(s); > diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_inter= nal.h > index e5f514c..ae40f73 100644 > --- a/hw/i386/intel_iommu_internal.h > +++ b/hw/i386/intel_iommu_internal.h > @@ -190,6 +190,7 @@ > #define VTD_CAP_MAMV (VTD_MAMV << 48) > #define VTD_CAP_PSI (1ULL << 39) > #define VTD_CAP_SLLPS ((1ULL << 34) | (1ULL << 35)) > +#define VTD_CAP_CM (1ULL << 7) > =20 > /* Supported Adjusted Guest Address Widths */ > #define VTD_CAP_SAGAW_SHIFT 8 >=20 --pL1wNRgEmphrqHhLFOimAP8k11UqDoUHu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAldAj9wACgkQitSsb3rl5xThqgCfdxejs66Beu3qfnvUva9zrBTZ ziwAoKVBTIrQPcp6ZvMsp7Oq3lNpwGs7 =sL/I -----END PGP SIGNATURE----- --pL1wNRgEmphrqHhLFOimAP8k11UqDoUHu--