From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4vLg-0000h4-0I for qemu-devel@nongnu.org; Mon, 23 May 2016 15:17:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4vLd-0002yZ-Tf for qemu-devel@nongnu.org; Mon, 23 May 2016 15:17:06 -0400 References: <1464008051-6429-1-git-send-email-pbonzini@redhat.com> <1464008051-6429-7-git-send-email-pbonzini@redhat.com> From: Eric Blake Message-ID: <57435727.8040802@redhat.com> Date: Mon, 23 May 2016 13:16:55 -0600 MIME-Version: 1.0 In-Reply-To: <1464008051-6429-7-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="22C09lgsrbpttD4rsUBPu4lSLwfaqeM3U" Subject: Re: [Qemu-devel] [PATCH 6/7] scsi-disk: introduce scsi_disk_req_check_error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --22C09lgsrbpttD4rsUBPu4lSLwfaqeM3U Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/23/2016 06:54 AM, Paolo Bonzini wrote: > Commonize all the checks for canceled requests and errors. The next pa= tch > will add another case to check for, in order to handle passthrough comm= ands. >=20 > There is no semantic change here; the only nontrivial modification is i= n > scsi_write_do_fua, where cancellation has been checked earlier by both > callers. Thus, the check is replaced with an assertion. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/scsi/scsi-disk.c | 89 +++++++++++++--------------------------------= -------- > 1 file changed, 22 insertions(+), 67 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --22C09lgsrbpttD4rsUBPu4lSLwfaqeM3U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXQ1cnAAoJEKeha0olJ0NqtcsH/1eSMXhp8HCCSbGdaKIxAL/X L3DxKFfBhQN837t1hQKKLlxK823ATmr6LKlY+ACrdVA929dX7ngGmI4D/6iN/o0q HZh5ccEY3WRtyMh0u3vmxAntAblXmQzlB8/c2Lys1ppCVUF31tw/yjoaipnafGYv Sd2TJrPf0LHg2cSsI+avy89ZvCSQWVRZ+R/Zh80pkEOEbOXjleHmLTmWsAMegT4y zBjT2fyGcFnhFOKpnQd9Z7/1PRDb2RkspjDDoF608kiQ13zEEU1pwReC4qzeUJk0 VRLhRpUFFBYJdnQJHC/Vsg+uQELLJ487n+LE9cHY5aBJkCHOEKVpsVxKx205FV4= =NNWX -----END PGP SIGNATURE----- --22C09lgsrbpttD4rsUBPu4lSLwfaqeM3U--