From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4xEK-0007iQ-6h for qemu-devel@nongnu.org; Mon, 23 May 2016 17:17:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4xEJ-0005u1-3l for qemu-devel@nongnu.org; Mon, 23 May 2016 17:17:40 -0400 References: <1464022515-11390-1-git-send-email-kwolf@redhat.com> <1464022515-11390-4-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5743736C.3090101@redhat.com> Date: Mon, 23 May 2016 15:17:32 -0600 MIME-Version: 1.0 In-Reply-To: <1464022515-11390-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QFf6PvkMPsqwkCkD9OSpURbX4iHFBTT5K" Subject: Re: [Qemu-devel] [PATCH 3/4] block: Fix reconfiguring graph with drained nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: pbonzini@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QFf6PvkMPsqwkCkD9OSpURbX4iHFBTT5K Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/23/2016 10:55 AM, Kevin Wolf wrote: > When changing the BlockDriverState that a BdrvChild points to while the= > node is currently drained, we must call the .drained_end() parent > callback. Conversely, when this means attaching a new node that is > already drained, we need to call .drained_begin(). >=20 > bdrv_root_attach_child() takes now an opaque parameter, which is needed= > because the callbacks must also be called if we're attaching a new chil= d > to the BlockBackend when the root node is already drained, and they nee= d > a way to identify the BlockBackend. Previously, child->opaque was set > too late and the callbacks would still see it as NULL. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 18 ++++++++++++++---- > block/block-backend.c | 9 +++++---- > include/block/block_int.h | 3 ++- > 3 files changed, 21 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QFf6PvkMPsqwkCkD9OSpURbX4iHFBTT5K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXQ3NtAAoJEKeha0olJ0NqQ/EH/2DESV/eB2tjeceJCOKKgxzZ 7STQYoqtofgbHS1ThGhkFgCyKgNHHW5YZ6C8LtqbXOdWjarZPr8NCZGggdz+zDJO BhT0CM2mPhc/Z9XB5nrx7ovGct25FKFWKweVnbVNqaF43cEnij2ZW5kcxw/NUXGa JdMaH2ClkkzS8uvdd9dOeTn2P6FW3w+7liKwsuCwflaQn8ninUBkpTVOw3zZTxeu 7jIVrq54iQjrL2XLA3NTaEEHCKoj2ojBenYJqMnGSUNklOVkJBWEDAsTFAv6zhKU muhUyRd/gQVDtw/dbQ1bZkBiAd8pHP8XX1eO+Ijs9WiO05gReuqr4DBAlaQfiFQ= =kWcF -----END PGP SIGNATURE----- --QFf6PvkMPsqwkCkD9OSpURbX4iHFBTT5K--