From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b54xy-0007fk-Sd for qemu-devel@nongnu.org; Tue, 24 May 2016 01:33:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b54xu-0001gD-Rd for qemu-devel@nongnu.org; Tue, 24 May 2016 01:33:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b54xu-0001g9-Il for qemu-devel@nongnu.org; Tue, 24 May 2016 01:33:14 -0400 References: <1463969642-5908-1-git-send-email-jasowang@redhat.com> From: Jason Wang Message-ID: <5743E793.4030007@redhat.com> Date: Tue, 24 May 2016 13:33:07 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/20] Net patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Leonid Bloch On 2016=E5=B9=B405=E6=9C=8823=E6=97=A5 19:09, Peter Maydell wrote: > On 23 May 2016 at 03:13, Jason Wang wrote: >> The following changes since commit 65603e2fc18b48e6e55a3dd693669413141= 694ec: >> >> tci: do not include exec/exec-all.h (2016-05-20 15:07:46 +0100) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to c5247aedff1e4580bc3cce86ae53a93571ef930= 9: >> >> net/net: Add SocketReadState for reuse codes (2016-05-23 09:51:24 += 0800) >> >> ---------------------------------------------------------------- >> >> Main changes: >> >> - e1000e emulation >> - convet vmxnet3 to use DMA api > Hi; I'm afraid this fails to build on 32 bit hosts and OSX, > because of errors like this: > > ./trace/generated-tracers.h: In function 'trace_net_rx_pkt_parsed': > ./trace/generated-tracers.h:18565:9: error: format '%lu' expects > argument of type 'long unsigned int', but ar > gument 9 has type 'size_t' [-Werror=3Dformat=3D] > qemu_log_mask(LOG_TRACE, "%d@%zd.%06zd:net_rx_pkt_parsed " > "RX packet parsed: ip4: %d, ip6: %d, udp: > %d, tcp: %d, l3 offset: %lu, l4 offset: %lu, l5 offset: %lu" "\n", > ^ > ./trace/generated-tracers.h:18565:9: error: format '%lu' expects > argument of type 'long unsigned int', but argument 10 has type > 'size_t' [-Werror=3Dformat=3D] > ./trace/generated-tracers.h:18565:9: error: format '%lu' expects > argument of type 'long unsigned int', but argument 11 has type > 'size_t' [-Werror=3Dformat=3D] > ./trace/generated-tracers.h: In function 'trace_net_rx_pkt_l4_csum_calc= _csum': > ./trace/generated-tracers.h:18757:9: error: format '%lu' expects > argument of type 'long unsigned int', but argument 5 has type 'size_t' > [-Werror=3Dformat=3D] > qemu_log_mask(LOG_TRACE, > "%d@%zd.%06zd:net_rx_pkt_l4_csum_calc_csum " "L4 Checksum: L4 header > offset: %lu, length: %u, counter: 0x%X, final checksum: 0x%X" "\n", > ^ > ./trace/generated-tracers.h: In function > 'trace_net_rx_pkt_l3_csum_validate_csum': > ./trace/generated-tracers.h:18877:9: error: format '%lu' expects > argument of type 'long unsigned int', but argument 5 has type 'size_t' > [-Werror=3Dformat=3D] > qemu_log_mask(LOG_TRACE, > "%d@%zd.%06zd:net_rx_pkt_l3_csum_validate_csum " "L3 Checksum: L3 > header offset: %lu, length: %u, counter: 0x%X, final checksum: 0x%X, > valid: %d" "\n", > ^ > ./trace/generated-tracers.h: In function 'trace_net_rx_pkt_rss_hash': > ./trace/generated-tracers.h:18949:9: error: format '%lu' expects > argument of type 'long unsigned int', but argument 5 has type 'size_t' > [-Werror=3Dformat=3D] > qemu_log_mask(LOG_TRACE, "%d@%zd.%06zd:net_rx_pkt_rss_hash " > "RSS hash for %lu bytes: 0x%X" "\n", > ^ > > (these aren't the only ones, please check all your trace > format strings). > > thanks > -- PMM Sorry for the failure, I tested 32bit cross build on 64bit guest, but=20 looks like this is not sufficient. Will fix and send V2 soon. Thanks