* [Qemu-devel] [PATCH] hw: Clean up includes
@ 2016-05-24 15:28 Peter Maydell
2016-05-24 15:57 ` Eric Blake
2016-05-29 8:37 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2016-05-24 15:28 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: patches
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.
This commit was created with scripts/clean-includes.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/intc/aspeed_vic.c | 1 -
hw/timer/mc146818rtc.c | 1 -
include/exec/hwaddr.h | 1 -
include/qemu/fifo32.h | 1 -
4 files changed, 4 deletions(-)
diff --git a/hw/intc/aspeed_vic.c b/hw/intc/aspeed_vic.c
index 725d5b6..2370e74 100644
--- a/hw/intc/aspeed_vic.c
+++ b/hw/intc/aspeed_vic.c
@@ -28,7 +28,6 @@
*/
#include "qemu/osdep.h"
-#include <inttypes.h>
#include "hw/intc/aspeed_vic.h"
#include "qemu/bitops.h"
#include "qemu/log.h"
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 2ac0fd3..a11b8b4 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -22,7 +22,6 @@
* THE SOFTWARE.
*/
#include "qemu/osdep.h"
-#include "config-target.h"
#include "qemu/cutils.h"
#include "qemu/bcd.h"
#include "hw/hw.h"
diff --git a/include/exec/hwaddr.h b/include/exec/hwaddr.h
index bb41588..a71c93c 100644
--- a/include/exec/hwaddr.h
+++ b/include/exec/hwaddr.h
@@ -3,7 +3,6 @@
#ifndef HWADDR_H
#define HWADDR_H
-#include <inttypes.h>
#define HWADDR_BITS 64
/* hwaddr is the type of a physical address (its size can
diff --git a/include/qemu/fifo32.h b/include/qemu/fifo32.h
index 2e5a0cc..4e9fd1b 100644
--- a/include/qemu/fifo32.h
+++ b/include/qemu/fifo32.h
@@ -15,7 +15,6 @@
#ifndef FIFO32_H
#define FIFO32_H
-#include "qemu/osdep.h"
#include "qemu/fifo8.h"
typedef struct {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw: Clean up includes
2016-05-24 15:28 [Qemu-devel] [PATCH] hw: Clean up includes Peter Maydell
@ 2016-05-24 15:57 ` Eric Blake
2016-05-29 8:37 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2016-05-24 15:57 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On 05/24/2016 09:28 AM, Peter Maydell wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/intc/aspeed_vic.c | 1 -
> hw/timer/mc146818rtc.c | 1 -
> include/exec/hwaddr.h | 1 -
> include/qemu/fifo32.h | 1 -
> 4 files changed, 4 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw: Clean up includes
2016-05-24 15:28 [Qemu-devel] [PATCH] hw: Clean up includes Peter Maydell
2016-05-24 15:57 ` Eric Blake
@ 2016-05-29 8:37 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2016-05-29 8:37 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: patches
Aplied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-29 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-24 15:28 [Qemu-devel] [PATCH] hw: Clean up includes Peter Maydell
2016-05-24 15:57 ` Eric Blake
2016-05-29 8:37 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).