From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Fg4-0000Yv-Pf for qemu-devel@nongnu.org; Tue, 24 May 2016 12:59:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Ffx-0003PM-LF for qemu-devel@nongnu.org; Tue, 24 May 2016 12:59:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Ffx-0003PG-Ff for qemu-devel@nongnu.org; Tue, 24 May 2016 12:59:25 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 004E0C05B1C8 for ; Tue, 24 May 2016 16:59:25 +0000 (UTC) References: <1463496205-251412-1-git-send-email-imammedo@redhat.com> <1463496205-251412-3-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <5744885F.6070306@redhat.com> Date: Tue, 24 May 2016 19:59:11 +0300 MIME-Version: 1.0 In-Reply-To: <1463496205-251412-3-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/33] acpi: add aml_debug() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, rkrcmar@redhat.com, ehabkost@redhat.com, drjones@redhat.com, armbru@redhat.com On 05/17/2016 05:42 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 9 +++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index cedb74e..f7d99be 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -406,6 +406,15 @@ Aml *aml_return(Aml *val) > return var; > } > > +/* ACPI 1.0b: 16.2.6.3 Debug Objects Encoding: DebugObj */ > +Aml *aml_debug(void) > +{ > + Aml *var = aml_alloc(); > + build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */ > + build_append_byte(var->buf, 0x31); /* DebugOp */ > + return var; > +} > + > /* > * ACPI 1.0b: 16.2.3 Data Objects Encoding: > * encodes: ByteConst, WordConst, DWordConst, QWordConst, ZeroOp, OneOp > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 7eb51c7..70a4b14 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -252,6 +252,7 @@ void aml_append(Aml *parent_ctx, Aml *child); > /* non block AML object primitives */ > Aml *aml_name(const char *name_format, ...) GCC_FMT_ATTR(1, 2); > Aml *aml_name_decl(const char *name, Aml *val); > +Aml *aml_debug(void); > Aml *aml_return(Aml *val); > Aml *aml_int(const uint64_t val); > Aml *aml_arg(int pos); > Reviewed-by: Marcel Apfelbaum Thanks, Marcel