From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Nvv-0005P1-Ao for qemu-devel@nongnu.org; Tue, 24 May 2016 21:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Nvu-0006dW-Bu for qemu-devel@nongnu.org; Tue, 24 May 2016 21:48:27 -0400 References: <1464097654-12977-1-git-send-email-kwolf@redhat.com> <1464097654-12977-9-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <57450461.9030500@redhat.com> Date: Tue, 24 May 2016 19:48:17 -0600 MIME-Version: 1.0 In-Reply-To: <1464097654-12977-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5kRFNkMlgQk91Lj2aBq59dSNOO8dVJsro" Subject: Re: [Qemu-devel] [PATCH v2 08/14] mirror: Use BlockBackend for I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, jsnow@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5kRFNkMlgQk91Lj2aBq59dSNOO8dVJsro Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/24/2016 07:47 AM, Kevin Wolf wrote: > This changes the mirror block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the mirroring code any more > afterwards. >=20 > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 74 ++++++++++++++++++++++++++++++++------------------= -------- > blockdev.c | 4 +--- > 2 files changed, 42 insertions(+), 36 deletions(-) >=20 > @@ -295,18 +297,19 @@ static void mirror_do_zero_or_discard(MirrorBlock= Job *s, > s->in_flight++; > s->sectors_in_flight +=3D nb_sectors; > if (is_discard) { > - bdrv_aio_discard(s->target, sector_num, op->nb_sectors, > - mirror_write_complete, op); > + blk_aio_discard(s->target, sector_num, op->nb_sectors, > + mirror_write_complete, op); Eventually, discard should be converted to bytes. (Did I just get volunteered?) > } else { > - bdrv_aio_write_zeroes(s->target, sector_num, op->nb_sectors, > - s->unmap ? BDRV_REQ_MAY_UNMAP : 0, > - mirror_write_complete, op); > + blk_aio_write_zeroes(s->target, sector_num * BDRV_SECTOR_SIZE,= > + op->nb_sectors * BDRV_SECTOR_SIZE, > + s->unmap ? BDRV_REQ_MAY_UNMAP : 0, > + mirror_write_complete, op); Conflicts with the write_zeroes stuff I just posted, let me know if I need to rebase mine. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5kRFNkMlgQk91Lj2aBq59dSNOO8dVJsro Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXRQRhAAoJEKeha0olJ0Nq+tMIAJup0Hprm/r95qJlxF8ZNhiq l9fmWSDdjFlzXk6QgQX9gr8PfsBfVBJcBLDeZUWuocNPwzgNYzRZDPHABxI7IiNy pbmNOaSPJJ9p1ovmamfvK/R/kkctUz4q9XL9bifBmhCJxzOzsUEC5jSSYb0BRTv9 C6DJVLV0R3ZK7oUrcRRQr0irRR9askPC1PgqVKtMRVbO+HUjeDgjXpT+2WirPnD+ cJtD2p4YyaDAVzSzW2LT/gXWtYn5CcknA5gOdLZYRTGnE+Ux5mHRIHae7y525pri xkf26tUJmnKC+whHXb+pZcc0rgXVP+D/Ll8v2pNu1Z+kavMAJMHRwc+/2vWOcVg= =UOJA -----END PGP SIGNATURE----- --5kRFNkMlgQk91Lj2aBq59dSNOO8dVJsro--