From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50017)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1b5Q7d-0003Fu-E2
	for qemu-devel@nongnu.org; Wed, 25 May 2016 00:08:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1b5Q7b-00022J-At
	for qemu-devel@nongnu.org; Wed, 25 May 2016 00:08:40 -0400
Message-ID: <57452622.7030409@cn.fujitsu.com>
Date: Wed, 25 May 2016 12:12:18 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1464097654-12977-1-git-send-email-kwolf@redhat.com>
	<1464097654-12977-9-git-send-email-kwolf@redhat.com>
	<57452141.2060001@cn.fujitsu.com> <574523B4.3010305@redhat.com>
In-Reply-To: <574523B4.3010305@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 08/14] mirror: Use BlockBackend for I/O
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: jsnow@redhat.com, jcody@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mreitz@redhat.com

On 05/25/2016 12:01 PM, Eric Blake wrote:
> On 05/24/2016 09:51 PM, Changlong Xie wrote:
>> On 05/24/2016 09:47 PM, Kevin Wolf wrote:
>>> +    s->target = blk_new();
>> blk_new(errp);
>
> Depends on Kevin's block/next branch, which currently includes:
>
> commit 5d7dd50566a4f9786b95f49448f48fead0bb34d8
> Author: Max Reitz <mreitz@redhat.com>
> Date:   Tue May 17 16:41:34 2016 +0200
>
>      block: Drop errp parameter from blk_new()
>
>      blk_new() cannot fail so its Error ** parameter has become superfluous.
>
>      Signed-off-by: Max Reitz <mreitz@redhat.com>
>      Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>
> So the patch builds as written when applied to the correct branch.
> http://repo.or.cz/qemu/kevin.git
>

Thanks for you reminder.