From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5TsF-0005Mg-My for qemu-devel@nongnu.org; Wed, 25 May 2016 04:09:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Ts8-0002gG-FQ for qemu-devel@nongnu.org; Wed, 25 May 2016 04:09:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Ts8-0002gB-9R for qemu-devel@nongnu.org; Wed, 25 May 2016 04:08:56 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C921AC000407 for ; Wed, 25 May 2016 08:08:55 +0000 (UTC) References: <1464034485-30543-1-git-send-email-wexu@redhat.com> <57440AB8.604@redhat.com> <20160524112527-mutt-send-email-mst@redhat.com> From: Jason Wang Message-ID: <57455D92.3080008@redhat.com> Date: Wed, 25 May 2016 16:08:50 +0800 MIME-Version: 1.0 In-Reply-To: <20160524112527-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [ RFC Patch v5 0/2] Support Receive-Segment-Offload(RSC) for WHQL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: victork@redhat.com, yvugenfi@redhat.com, qemu-devel@nongnu.org, wexu@redhat.com, marcel@redhat.com, dfleytma@redhat.com On 2016=E5=B9=B405=E6=9C=8824=E6=97=A5 16:26, Michael S. Tsirkin wrote: > On Tue, May 24, 2016 at 04:03:04PM +0800, Jason Wang wrote: >> > >> > >> >On 2016=E5=B9=B405=E6=9C=8824=E6=97=A5 04:14,wexu@redhat.com wrote: >>> > >From: Wei Xu >>> > > >>> > >Changes in V5: >>> > >- Passed all IPv4/6 test cases >>> > >- Add new fields in 'virtio_net_hdr' >>> > >- Set 'gso_type' & 'coalesced packets' in new field. >>> > >- Bypass all 'tcp option' packet >>> > >- Bypass all 'pure ack' packet >>> > >- Bypass all 'duplicate ack' packet >>> > >- Change 'guest_rsc' feature bit to 'false' by default >>> > >- Feedbacks from v4, typo, etc. >> > >> >Patch does not apply on master ... >> > >>> > > >>> > >Note: >>> > >There is still a few pending issues about the feature bit, and nee= d to be >>> > >discussed with windows driver maintainer, so linux guests with thi= s patch >>> > >won't work at current, haven't figure it out yet, but i'm guessing= it's >>> > >caused by the 'gso_type' is set to 'VIRTIO_NET_HDR_GSO_TCPV4/6', >>> > >will fix it after get the final solution, the below test steps and >>> > >performance data is based on v4. >> > >> >Can we split the patches into smaller ones to make review or merging = easier? >> >E.g can we send the patches without any feature negotiation and vnet = header >> >extension? >> > >> >We can focus on the coalescing (maybe ipv4) without any guest involve= ment in >> >this series. In this way, the issues were limited and can be converge= d soon. >> >After this has been merged, we can add patches that co-operate with g= uests >> >on top (since it needs agreement on virtio specs). Does this sounds a= good >> >plan? > True but disabling everything when feature is not negotiated > reduces the risk somewhat. > Yes, but I believe we can only merge the patch with new virtio features=20 after they were accepted by spec?