From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Uqs-0004qd-Uv for qemu-devel@nongnu.org; Wed, 25 May 2016 05:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Uqm-0000du-Vf for qemu-devel@nongnu.org; Wed, 25 May 2016 05:11:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Uqm-0000do-NJ for qemu-devel@nongnu.org; Wed, 25 May 2016 05:11:36 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5512AC04B303 for ; Wed, 25 May 2016 09:11:36 +0000 (UTC) References: <1463496205-251412-1-git-send-email-imammedo@redhat.com> <1463496205-251412-5-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <57456C45.5030309@redhat.com> Date: Wed, 25 May 2016 12:11:33 +0300 MIME-Version: 1.0 In-Reply-To: <1463496205-251412-5-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/33] pc: acpi: remove AML for empty/not used GPE handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, rkrcmar@redhat.com, ehabkost@redhat.com, drjones@redhat.com, armbru@redhat.com On 05/17/2016 05:42 PM, Igor Mammedov wrote: > ACPI spec requires GPE handlers only for GPE events > that hardware implements. > So remove AML for not supported by QEMU device model > events. > > Signed-off-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 279f0d7..ff98ad8 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2051,8 +2051,6 @@ build_dsdt(GArray *table_data, GArray *linker, > { > aml_append(scope, aml_name_decl("_HID", aml_string("ACPI0006"))); > > - aml_append(scope, aml_method("_L00", 0, AML_NOTSERIALIZED)); > - > if (misc->is_piix4) { > method = aml_method("_E01", 0, AML_NOTSERIALIZED); > aml_append(method, > @@ -2060,8 +2058,6 @@ build_dsdt(GArray *table_data, GArray *linker, > aml_append(method, aml_call0("\\_SB.PCI0.PCNT")); > aml_append(method, aml_release(aml_name("\\_SB.PCI0.BLCK"))); > aml_append(scope, method); > - } else { > - aml_append(scope, aml_method("_L01", 0, AML_NOTSERIALIZED)); > } > > method = aml_method("_E02", 0, AML_NOTSERIALIZED); > @@ -2071,19 +2067,6 @@ build_dsdt(GArray *table_data, GArray *linker, > method = aml_method("_E03", 0, AML_NOTSERIALIZED); > aml_append(method, aml_call0(MEMORY_HOTPLUG_HANDLER_PATH)); > aml_append(scope, method); > - > - aml_append(scope, aml_method("_L04", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L05", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L06", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L07", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L08", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L09", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L0A", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L0B", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L0C", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L0D", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L0E", 0, AML_NOTSERIALIZED)); > - aml_append(scope, aml_method("_L0F", 0, AML_NOTSERIALIZED)); > } > aml_append(dsdt, scope); > > Is this patch related to the series? Or is it a cleanup opportunity? Thanks, Marcel