From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5bo7-0007zo-F6 for qemu-devel@nongnu.org; Wed, 25 May 2016 12:37:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5bo2-0002pY-EL for qemu-devel@nongnu.org; Wed, 25 May 2016 12:37:19 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:35262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5bo1-0002pR-O2 for qemu-devel@nongnu.org; Wed, 25 May 2016 12:37:14 -0400 Received: by mail-lf0-x241.google.com with SMTP id p10so3736296lfb.2 for ; Wed, 25 May 2016 09:37:13 -0700 (PDT) References: <1463404380-29302-1-git-send-email-sergey.fedorov@linaro.org> <53a44acc-2a09-c321-a649-85e659bbc1e6@twiddle.net> <5739DAE2.3010802@gmail.com> From: Sergey Fedorov Message-ID: <5745D4B7.40705@gmail.com> Date: Wed, 25 May 2016 19:37:11 +0300 MIME-Version: 1.0 In-Reply-To: <5739DAE2.3010802@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , Sergey Fedorov , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Peter Crosthwaite On 16/05/16 17:36, Sergey Fedorov wrote: > On 16/05/16 16:49, Richard Henderson wrote: >> On 05/16/2016 06:13 AM, Sergey Fedorov wrote: >>> It is not safe to make a direct jump to a TB spanning two pages in >>> system emulation because the mapping for the second page can get changed >>> but we don't take care of direct jumps in this case. >> We don't? I'm pretty sure that we do... > What we just do is flushing the CPU virtual address cache, see for > tlb_flush() etc. Ping. This patch fixed a bug discussed in this thread: http://thread.gmane.org/gmane.comp.emulators.qemu/411648 Kind regards, Sergey