From: xiaoqiang zhao <zxq_yx_007@163.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Alistair Francis" <alistair.francis@xilinx.com>,
qemu-arm <qemu-arm@nongnu.org>,
"Антон Павлов" <antonynpavlov@gmail.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model
Date: Fri, 27 May 2016 10:13:21 +0800 [thread overview]
Message-ID: <5747AD41.9050007@163.com> (raw)
In-Reply-To: <963b4bae-1f00-7406-6de7-f0bd3be8d2bb@redhat.com>
在 2016年05月25日 21:15, Paolo Bonzini 写道:
>>>> @@ -310,8 +312,7 @@ static void pl011_class_init(ObjectClass *oc, void *data)
>>>> >> >
>>>> >> > dc->realize = pl011_realize;
>>>> >> > dc->vmsd = &vmstate_pl011;
>>>> >> >- /* Reason: realize() method uses qemu_char_get_next_serial() */
>>>> >> >- dc->cannot_instantiate_with_device_add_yet = true;
>> >Why does instantiating with device_add work now? There's
>> >still no way to wire up interrupt lines or map mmio regions.
>> >(This has never made much sense to me -- Markus?)
> You can create it with -device if your board provides a platform bus and
> there's an FDT creator function. If you don't, you get an error.
>
> Regarding device_add, it's disabled anyway because sysbus is not
> hotpluggable.
>
> Eiter way it's safe to remove this line, which is for outliers that
> otherwise would not give any error message.
Paolo: Do I need to send a new version to keep the
"dc->cannot_instantiate_with_device_add_yet = true"
untouched ?
next prev parent reply other threads:[~2016-05-27 2:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 10:58 [Qemu-devel] [PATCH 0/6] Drop the qemu_char_get_next_serial function xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model xiaoqiang zhao
2016-05-25 13:01 ` Paolo Bonzini
2016-05-25 13:08 ` Peter Maydell
2016-05-25 13:15 ` Paolo Bonzini
2016-05-27 2:13 ` xiaoqiang zhao [this message]
2016-05-27 9:40 ` Paolo Bonzini
2016-05-27 2:06 ` xiaoqiang zhao
2016-05-27 9:01 ` Peter Maydell
2016-05-27 9:42 ` Paolo Bonzini
2016-05-27 11:36 ` xiaoqiang zhao
2016-05-30 11:35 ` Markus Armbruster
2016-05-25 10:58 ` [Qemu-devel] [PATCH 2/6] hw/char: QOM'ify cadence_uart model xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-devel] [PATCH 3/6] hw/char: QOM'ify digic-uart model xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-devel] [PATCH 4/6] hw/char: QOM'ify stm32f2xx_usart model xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-devel] [PATCH 5/6] hw/char: QOM'ify xilinx_uartlite model xiaoqiang zhao
2016-05-25 10:58 ` [Qemu-devel] [PATCH 6/6] char: get rid of qemu_char_get_next_serial xiaoqiang zhao
2016-05-25 13:03 ` Paolo Bonzini
2016-05-25 13:03 ` [Qemu-devel] [PATCH 0/6] Drop the qemu_char_get_next_serial function Paolo Bonzini
2016-06-03 18:24 ` Peter Maydell
2016-06-04 7:13 ` xiaoqiang zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5747AD41.9050007@163.com \
--to=zxq_yx_007@163.com \
--cc=alistair.francis@xilinx.com \
--cc=antonynpavlov@gmail.com \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).