From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b69bB-0005a2-Iy for qemu-devel@nongnu.org; Fri, 27 May 2016 00:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b69b7-0006Fr-7w for qemu-devel@nongnu.org; Fri, 27 May 2016 00:42:12 -0400 References: <1462291414-8343-1-git-send-email-clg@kaod.org> <1462291414-8343-8-git-send-email-clg@kaod.org> <20160527033832.GS17226@voom.fritz.box> From: Thomas Huth Message-ID: <5747D010.2060409@redhat.com> Date: Fri, 27 May 2016 06:41:52 +0200 MIME-Version: 1.0 In-Reply-To: <20160527033832.GS17226@voom.fritz.box> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pax4l9oWHJS2v9EsGLD4oJkGGcuGeaSbC" Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/12] ppc: Better figure out if processor has HV mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pax4l9oWHJS2v9EsGLD4oJkGGcuGeaSbC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 27.05.2016 05:38, David Gibson wrote: > On Tue, May 03, 2016 at 06:03:29PM +0200, C=C3=A9dric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> We use an env. flag which is set to the initial value of MSR_HVB in >> the msr_mask. We also adjust the POWER8 mask to set SHV. >> >> Also use this to adjust ctx.hv so that it is *set* when the processor >> doesn't have an HV mode (970 with Apple mode for example), thus enabli= ng >> hypervisor instructions/SPRs. >> >> Signed-off-by: Benjamin Herrenschmidt >> Reviewed-by: David Gibson >> --- >> target-ppc/cpu.h | 4 ++++ >> target-ppc/translate.c | 4 +++- >> target-ppc/translate_init.c | 21 ++++++++++++++++----- >> 3 files changed, 23 insertions(+), 6 deletions(-) =2E.. >> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c= >> index 10a92fdbbdd7..df656e6021b4 100644 >> --- a/target-ppc/translate_init.c >> +++ b/target-ppc/translate_init.c >> @@ -8579,7 +8579,8 @@ POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *da= ta) >> PPC2_ISA205 | PPC2_ISA207S | PPC2_FP_CVT_S64 = | >> PPC2_TM; >> pcc->msr_mask =3D (1ull << MSR_SF) | >> - (1ull << MSR_TM) | >> + (1ull << MSR_SHV) | >> + (1ull << MSR_TM) | >> (1ull << MSR_VR) | >> (1ull << MSR_VSX) | >> (1ull << MSR_EE) | This indentation looks somewhat suspicious ... and indeed, checkpatch compains here: ERROR: code indent should never use tabs #153: FILE: target-ppc/translate_init.c:8583: +^I^I (1ull << MSR_TM) |$ total: 1 errors, 0 warnings, 60 lines checked Please fix it to use spaces instead. Thomas --pax4l9oWHJS2v9EsGLD4oJkGGcuGeaSbC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXR9AVAAoJEC7Z13T+cC21jvUP/1h/wQyBEFfd/kX7kI/6zqCW TvdixhksAIRBRnAfoMTCBeMS65bhgzzb8FU+RZvIXGE3pt7+z9y4EnBfyBxU1X8Z FakZq45KyVd4Rtvw4GAtNkCQPjCyokUkjGGarX3igUf8n4DT5+FcNm9Dav0Y972D GpLA04ce8XcXVuzrrIeCR1HdoSBVmcEuN5CiZtL03gfVuljrT+FLVm8W5tEq6wE0 Q4ep2qYSKK0nKy+X9VIHPHVolArNhCvV7rZpmhbgs4P5t9/3jOfYQa7YaD2SdXaV Nk72xjn235FP5yih2coTqWsBK/eYfrpoUtSvlbnuF9Z4PgdWXe873Eyzy/mNNeze G5EolQ5YSsoy6tH5KzRghduQhoGetpPCud54D7sVlXdW1bqcqBeyp5E1QteWOBby jo9olNtlSybTVHnypRk6roLKIhA4VBfgZpmP022FN7I7yvBoRELaM2/THa+M/axb qq8I503kr1SyER5SrIa5WYyNr7sGOD6A7LsEmQr9PfZpx/jFK3K+rTYmPP9hf170 yKjsSre7CD/VDf2Xv1XeJizzBBS8J1lIf0bkm9mxAx66ECirHMVxVVvJ36LDsAUA YglK7kY9jGsRbkeevwr25AG7hlxXTnYChTAx9+kByM85prr4XhCb+3MleFDRkYVe +fpil1/mxvM2oDQjFInb =iQT9 -----END PGP SIGNATURE----- --pax4l9oWHJS2v9EsGLD4oJkGGcuGeaSbC--