From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6CrI-00006m-SI for qemu-devel@nongnu.org; Fri, 27 May 2016 04:11:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6CrC-0001KI-Ll for qemu-devel@nongnu.org; Fri, 27 May 2016 04:11:03 -0400 Received: from mo179.mail-out.ovh.net ([178.32.228.179]:41750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6CrC-0001Jm-Fz for qemu-devel@nongnu.org; Fri, 27 May 2016 04:10:58 -0400 Received: from player715.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id 586B1FF8829 for ; Fri, 27 May 2016 10:10:57 +0200 (CEST) References: <1462291414-8343-1-git-send-email-clg@kaod.org> <1462291414-8343-8-git-send-email-clg@kaod.org> <20160527033832.GS17226@voom.fritz.box> <5747D010.2060409@redhat.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <57480100.4070909@kaod.org> Date: Fri, 27 May 2016 10:10:40 +0200 MIME-Version: 1.0 In-Reply-To: <5747D010.2060409@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 07/12] ppc: Better figure out if processor has HV mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 05/27/2016 06:41 AM, Thomas Huth wrote: > On 27.05.2016 05:38, David Gibson wrote: >> On Tue, May 03, 2016 at 06:03:29PM +0200, C=C3=A9dric Le Goater wrote: >>> From: Benjamin Herrenschmidt >>> >>> We use an env. flag which is set to the initial value of MSR_HVB in >>> the msr_mask. We also adjust the POWER8 mask to set SHV. >>> >>> Also use this to adjust ctx.hv so that it is *set* when the processor >>> doesn't have an HV mode (970 with Apple mode for example), thus enabl= ing >>> hypervisor instructions/SPRs. >>> >>> Signed-off-by: Benjamin Herrenschmidt >>> Reviewed-by: David Gibson >>> --- >>> target-ppc/cpu.h | 4 ++++ >>> target-ppc/translate.c | 4 +++- >>> target-ppc/translate_init.c | 21 ++++++++++++++++----- >>> 3 files changed, 23 insertions(+), 6 deletions(-) > ... >>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.= c >>> index 10a92fdbbdd7..df656e6021b4 100644 >>> --- a/target-ppc/translate_init.c >>> +++ b/target-ppc/translate_init.c >>> @@ -8579,7 +8579,8 @@ POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *d= ata) >>> PPC2_ISA205 | PPC2_ISA207S | PPC2_FP_CVT_S64= | >>> PPC2_TM; >>> pcc->msr_mask =3D (1ull << MSR_SF) | >>> - (1ull << MSR_TM) | >>> + (1ull << MSR_SHV) | >>> + (1ull << MSR_TM) | >>> (1ull << MSR_VR) | >>> (1ull << MSR_VSX) | >>> (1ull << MSR_EE) | >=20 > This indentation looks somewhat suspicious ... and indeed, checkpatch > compains here: >=20 > ERROR: code indent should never use tabs > #153: FILE: target-ppc/translate_init.c:8583: > +^I^I (1ull << MSR_TM) |$ >=20 > total: 1 errors, 0 warnings, 60 lines checked >=20 > Please fix it to use spaces instead. Sure. I will. Thanks for checking. A couple of other patches for PowerNV=20 are in the same state.=20 Sometimes I wish I had a reasonable 'indent' command line.=20 C.=20