From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Evs-0002Zq-CM for qemu-devel@nongnu.org; Fri, 27 May 2016 06:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6Evp-0002z6-7I for qemu-devel@nongnu.org; Fri, 27 May 2016 06:23:56 -0400 Received: from mail-lb0-x241.google.com ([2a00:1450:4010:c04::241]:34759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Evo-0002yw-UU for qemu-devel@nongnu.org; Fri, 27 May 2016 06:23:53 -0400 Received: by mail-lb0-x241.google.com with SMTP id t6so5597397lbv.1 for ; Fri, 27 May 2016 03:23:52 -0700 (PDT) References: <1464310815-13554-1-git-send-email-rth@twiddle.net> <1464310815-13554-11-git-send-email-rth@twiddle.net> From: Sergey Fedorov Message-ID: <57482035.2010208@gmail.com> Date: Fri, 27 May 2016 13:23:49 +0300 MIME-Version: 1.0 In-Reply-To: <1464310815-13554-11-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: Stefan Weil , bobby.prani@gmail.com On 27/05/16 04:00, Richard Henderson wrote: > diff --git a/tci.c b/tci.c > index b488c0d..53b3f71 100644 > --- a/tci.c > +++ b/tci.c > @@ -1236,6 +1236,9 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) > tcg_abort(); > } > break; > + case INDEX_op_fence: > + smp_mb(); > + break; > default: > TODO(); > break; A bit of bike-shedding. While there's no common ISA term for "memory barrier" (also known as a "membar", "memory fence", etc.), we already refer to it as a "memory barrier" (or "mb") in include/qemu/atomic.h and docs/atomics.txt. Why don't be consistent and avoid introducing yet another term for the same thing? Kind regards, Sergey