From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Jbd-0002hU-UL for qemu-devel@nongnu.org; Fri, 27 May 2016 11:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6Jbc-0006bv-1j for qemu-devel@nongnu.org; Fri, 27 May 2016 11:23:20 -0400 References: <1464338922-13102-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1464338922-13102-3-git-send-email-mark.cave-ayland@ilande.co.uk> <6ecc4f1a-5dd3-7567-51b4-52bdb937c0c9@redhat.com> From: Mark Cave-Ayland Message-ID: <5748663E.8030501@ilande.co.uk> Date: Fri, 27 May 2016 16:22:38 +0100 MIME-Version: 1.0 In-Reply-To: <6ecc4f1a-5dd3-7567-51b4-52bdb937c0c9@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] macio: switch over to new byte-aligned DMA helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, aurelien@aurel32.net On 27/05/16 16:02, John Snow wrote: > On 05/27/2016 04:48 AM, Mark Cave-Ayland wrote: >> Now that the DMA helpers are byte-aligned they can be called directly from >> the macio routines rather than emulating byte-aligned accesses via multiple >> block-level accesses. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/ide/macio.c | 213 ++++++++------------------------------------------------ > > ^ _cool_ ^ > > I assume you'll actually not be needing me to deal with this until you > resolve the HACK in the pre-requisite patch, yes? Yes, that's correct. The reason I posted it as-is was to provide Paolo with a test case and for Aurelien to verify the TRIM behaviour. Once the hack is no longer required, I'll resubmit it properly. ATB, Mark.