From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6dTD-00060V-Fv for qemu-devel@nongnu.org; Sat, 28 May 2016 08:36:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6dT8-0001Bt-7E for qemu-devel@nongnu.org; Sat, 28 May 2016 08:35:58 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6dT7-0001Bh-Vh for qemu-devel@nongnu.org; Sat, 28 May 2016 08:35:54 -0400 Received: by mail-lf0-x244.google.com with SMTP id h68so3604449lfh.3 for ; Sat, 28 May 2016 05:35:53 -0700 (PDT) References: <1464138802-23503-1-git-send-email-cota@braap.org> <1464138802-23503-5-git-send-email-cota@braap.org> <5748B3AD.4050304@gmail.com> <20160527211034.GA23409@flamenco> From: Sergey Fedorov Message-ID: <574990A6.4020506@gmail.com> Date: Sat, 28 May 2016 15:35:50 +0300 MIME-Version: 1.0 In-Reply-To: <20160527211034.GA23409@flamenco> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v6 04/15] include/processor.h: define cpu_relax() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" Cc: QEMU Developers , MTTCG Devel , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Richard Henderson On 28/05/16 00:10, Emilio G. Cota wrote: > On Fri, May 27, 2016 at 23:53:01 +0300, Sergey Fedorov wrote: >> On 25/05/16 04:13, Emilio G. Cota wrote: >>> Taken from the linux kernel. >>> >>> Reviewed-by: Richard Henderson >>> Reviewed-by: Alex Bennée >>> Signed-off-by: Emilio G. Cota >>> --- >>> include/qemu/processor.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> create mode 100644 include/qemu/processor.h >>> >>> diff --git a/include/qemu/processor.h b/include/qemu/processor.h >>> new file mode 100644 >>> index 0000000..42bcc99 >>> --- /dev/null >>> +++ b/include/qemu/processor.h >>> @@ -0,0 +1,30 @@ >>> +/* >>> + * Copyright (C) 2016, Emilio G. Cota >>> + * >> If it's taken from the Linux kernel shouldn't it be attributed here? > It's "taken" as in "we do like the kernel does", not as in > "we're just copying this code". > Well, then Reviewed-by: Sergey Fedorov Regards, Sergey