From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6uSR-0003ba-3L for qemu-devel@nongnu.org; Sun, 29 May 2016 02:44:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6uSL-00051d-8D for qemu-devel@nongnu.org; Sun, 29 May 2016 02:44:18 -0400 References: <1464503845-29545-1-git-send-email-sameeh@daynix.com> From: Stefan Weil Message-ID: <574A8FB2.6080602@weilnetz.de> Date: Sun, 29 May 2016 08:44:02 +0200 MIME-Version: 1.0 In-Reply-To: <1464503845-29545-1-git-send-email-sameeh@daynix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g1U6fumqo64pSOtJfcTohTSCuI9Vqcd7Q" Subject: Re: [Qemu-devel] [PATCH] e1000: Removing unnecessary if statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sameeh Jubran , qemu-devel@nongnu.org, Jason Wang Cc: QEMU Trivial , Yan Vugenfirer This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --g1U6fumqo64pSOtJfcTohTSCuI9Vqcd7Q Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Am 29.05.2016 um 08:37 schrieb Sameeh Jubran: > Since mit_delay can never be 0 this if statement is > superfluous. > > Signed-off-by: Sameeh Jubran > --- > hw/net/e1000.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c > index 8e79b55..eb903a9 100644 > --- a/hw/net/e1000.c > +++ b/hw/net/e1000.c > @@ -365,11 +365,9 @@ set_interrupt_cause(E1000State *s, int index, uint= 32_t val) > */ > mit_delay =3D (mit_delay < 500) ? 500 : mit_delay; > =20 > - if (mit_delay) { > - s->mit_timer_on =3D 1; > - timer_mod(s->mit_timer, qemu_clock_get_ns(QEMU_CLOCK_V= IRTUAL) + > - mit_delay * 256); > - } > + s->mit_timer_on =3D 1; > + timer_mod(s->mit_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTU= AL) + > + mit_delay * 256); > s->mit_ide =3D 0; > } > } Reviewed-by: Stefan Weil CC'ing qemu-trivial --g1U6fumqo64pSOtJfcTohTSCuI9Vqcd7Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXSo+5AAoJEOCMIdVndFCtupYP/jL1SN6pFMAedXQjLGakeBQL EStKAXlWZwr5/jan9NNzRB65xmtPM0TL6c2qUBoKo/fyC9wAqckjCs9EWHrwAVAr jnaISv093pI4V27Hpi72WthmzYZUFToPs4pPTl+ASujVU8xU37cUl054M8pRqPPc XqB8rOq2SZhA6Vbz43yuCdBVlxkpnslec2eJM+4++QUtQEJP/zyKkC9s5YMIxdi6 G1U30RspFrU54cjZZiO6zO96f5B/O8mqU/opxZbrZs/TQWHYiZocy3SCBj0awauU c5PATXlc2rBOVzf96NRHRvCPP4aaVaILg8QBTLS17eZRrpgSaK6puVquNjnuNcut TEJlzjVZJvoDIFNfxYRLPYb8FRdvJQxXQezWnwY4S9SLkMqzBCEXutbuUfNfwIqI 6OZJamQKNpHMWhK3npZdO6NlxVqIbpAA8KWXS0F0x5lhMK0lcmv3tA05Nr2mTBnn zp7E+3pXN/0XP6WNLt1wM0BKte+gdwW4i/CQvwhR6EZzoFuxyW8yQbfUrJ73lHIV 8kovZa6Nw2/4EMBXGMQP/Vozq25/59EXKC7CMgiXxhC2TvyDRlGSz/kAtEI6zPDI NlMdwmBRmCgIZyl9klqIXYLE1nJIXVBXmttqdlOMX8d2VBb3KJgWeM9M/vlNpZlU OlRdV/OKyFpwldmna5Xn =batF -----END PGP SIGNATURE----- --g1U6fumqo64pSOtJfcTohTSCuI9Vqcd7Q--