From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
To: Eric Blake <eblake@redhat.com>, Alberto Garcia <berto@igalia.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docs: Fix a couple of typos in throttle.txt
Date: Mon, 30 May 2016 14:49:18 +0800 [thread overview]
Message-ID: <574BE26E.9020106@cn.fujitsu.com> (raw)
In-Reply-To: <5744DFA3.1070806@redhat.com>
On 05/25/2016 07:11 AM, Eric Blake wrote:
> On 05/24/2016 05:59 AM, Alberto Garcia wrote:
>> Signed-off-by: Alberto Garcia <berto@igalia.com>
>> ---
>> docs/throttle.txt | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>>
>> diff --git a/docs/throttle.txt b/docs/throttle.txt
>> index 06ed9b3..b4431f6 100644
>> --- a/docs/throttle.txt
>> +++ b/docs/throttle.txt
>> @@ -39,7 +39,7 @@ the parameters for both cases:
>> | throttling.bps-write | bps_wr |
>> |-----------------------+-----------------------|
>>
>> -It is possible to set limits for both IOPS and bps and the same time,
>> +It is possible to set limits for both IOPS and bps at the same time,
>> and for each case we can decide whether to have separate read and
>> write limits or not, but note that if iops-total is set then neither
>> iops-read nor iops-write can be set. The same applies to bps-total and
>> @@ -235,7 +235,7 @@ consider the following values:
>> - Water leaks from the bucket at a rate of 100 IOPS.
>> - Water can be added to the bucket at a rate of 2000 IOPS.
>> - The size of the bucket is 2000 x 60 = 120000
>> - - If 'iops-total-max-length' is unset then the bucket size is 100.
>> + - If 'iops-total-max' is unset then the bucket size is 100.
Sorry to brother, why the bucket size is 100 rather than 100 x 60?
Thanks
-Xie
>>
>> The bucket is initially empty, therefore water can be added until it's
>> full at a rate of 2000 IOPS (the burst rate). Once the bucket is full
>>
>
next prev parent reply other threads:[~2016-05-30 6:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 11:59 [Qemu-devel] [PATCH] docs: Fix a couple of typos in throttle.txt Alberto Garcia
2016-05-24 23:11 ` Eric Blake
2016-05-30 6:49 ` Changlong Xie [this message]
2016-05-30 10:00 ` Alberto Garcia
2016-05-30 10:19 ` Changlong Xie
2016-06-01 8:01 ` Michael Tokarev
2016-05-29 8:39 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574BE26E.9020106@cn.fujitsu.com \
--to=xiecl.fnst@cn.fujitsu.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).