From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Rpt-0002tw-IY for qemu-devel@nongnu.org; Mon, 30 May 2016 14:22:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Rps-0004JP-Jh for qemu-devel@nongnu.org; Mon, 30 May 2016 14:22:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Rps-0004In-Dw for qemu-devel@nongnu.org; Mon, 30 May 2016 14:22:44 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F28DD81103 for ; Mon, 30 May 2016 18:22:43 +0000 (UTC) References: <1463496205-251412-1-git-send-email-imammedo@redhat.com> <1463496205-251412-7-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <574C84EE.8060007@redhat.com> Date: Mon, 30 May 2016 21:22:38 +0300 MIME-Version: 1.0 In-Reply-To: <1463496205-251412-7-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/33] pc: acpi: consolidate \GPE._E02 with the rest of CPU hotplug AML List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, rkrcmar@redhat.com, ehabkost@redhat.com, drjones@redhat.com, armbru@redhat.com On 05/17/2016 05:42 PM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/cpu_hotplug_acpi_table.c | 4 ++++ > hw/i386/acpi-build.c | 4 ---- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/acpi/cpu_hotplug_acpi_table.c b/hw/acpi/cpu_hotplug_acpi_table.c > index 730f44c..c31f346 100644 > --- a/hw/acpi/cpu_hotplug_acpi_table.c > +++ b/hw/acpi/cpu_hotplug_acpi_table.c > @@ -235,4 +235,8 @@ void build_cpu_hotplug_aml(Aml *ctx, MachineState *machine, > g_free(apic_ids); > > aml_append(ctx, sb_scope); > + > + method = aml_method("\\_GPE._E02", 0, AML_NOTSERIALIZED); > + aml_append(method, aml_call0("\\_SB." CPU_SCAN_METHOD)); > + aml_append(ctx, method); > } > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 822230f..63e2723 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1952,10 +1952,6 @@ build_dsdt(GArray *table_data, GArray *linker, > aml_append(scope, method); > } > > - method = aml_method("_E02", 0, AML_NOTSERIALIZED); > - aml_append(method, aml_call0("\\_SB." CPU_SCAN_METHOD)); > - aml_append(scope, method); > - > method = aml_method("_E03", 0, AML_NOTSERIALIZED); > aml_append(method, aml_call0(MEMORY_HOTPLUG_HANDLER_PATH)); > aml_append(scope, method); > Reviewed-by: Marcel Apfelbaum Thanks, Marcel