From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Rqe-0003Zy-Nl for qemu-devel@nongnu.org; Mon, 30 May 2016 14:23:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Rqa-0004OM-Gu for qemu-devel@nongnu.org; Mon, 30 May 2016 14:23:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Rqa-0004NB-B3 for qemu-devel@nongnu.org; Mon, 30 May 2016 14:23:28 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 005BAC05B1C7 for ; Mon, 30 May 2016 18:23:28 +0000 (UTC) References: <1463496205-251412-1-git-send-email-imammedo@redhat.com> <1463496205-251412-8-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <574C851A.5050903@redhat.com> Date: Mon, 30 May 2016 21:23:22 +0300 MIME-Version: 1.0 In-Reply-To: <1463496205-251412-8-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/33] pc: acpi: cpu-hotplug: make AML CPU_foo defines local to cpu_hotplug_acpi_table.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, rkrcmar@redhat.com, ehabkost@redhat.com, drjones@redhat.com, armbru@redhat.com On 05/17/2016 05:42 PM, Igor Mammedov wrote: > now as those defines are used only locally inside of > cpu_hotplug_acpi_table.c, move them out of header file. > > Signed-off-by: Igor Mammedov > --- > hw/acpi/cpu_hotplug_acpi_table.c | 7 +++++++ > include/hw/acpi/cpu_hotplug.h | 7 ------- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/hw/acpi/cpu_hotplug_acpi_table.c b/hw/acpi/cpu_hotplug_acpi_table.c > index c31f346..9fdde6d 100644 > --- a/hw/acpi/cpu_hotplug_acpi_table.c > +++ b/hw/acpi/cpu_hotplug_acpi_table.c > @@ -17,6 +17,13 @@ > #include "hw/acpi/cpu_hotplug.h" > #include "hw/i386/pc.h" > > +#define CPU_EJECT_METHOD "CPEJ" > +#define CPU_MAT_METHOD "CPMA" > +#define CPU_ON_BITMAP "CPON" > +#define CPU_STATUS_METHOD "CPST" > +#define CPU_STATUS_MAP "PRS" > +#define CPU_SCAN_METHOD "PRSC" > + > void build_cpu_hotplug_aml(Aml *ctx, MachineState *machine, > uint16_t io_base, uint16_t io_len) > { > diff --git a/include/hw/acpi/cpu_hotplug.h b/include/hw/acpi/cpu_hotplug.h > index 9b1d0cf..565f96c 100644 > --- a/include/hw/acpi/cpu_hotplug.h > +++ b/include/hw/acpi/cpu_hotplug.h > @@ -27,13 +27,6 @@ void acpi_cpu_plug_cb(ACPIREGS *ar, qemu_irq irq, > void acpi_cpu_hotplug_init(MemoryRegion *parent, Object *owner, > AcpiCpuHotplug *gpe_cpu, uint16_t base); > > -#define CPU_EJECT_METHOD "CPEJ" > -#define CPU_MAT_METHOD "CPMA" > -#define CPU_ON_BITMAP "CPON" > -#define CPU_STATUS_METHOD "CPST" > -#define CPU_STATUS_MAP "PRS" > -#define CPU_SCAN_METHOD "PRSC" > - > void build_cpu_hotplug_aml(Aml *ctx, MachineState *machine, > uint16_t io_base, uint16_t io_len); > #endif > Reviewed-by: Marcel Apfelbaum Thanks, Marcel