From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b7fNi-0000pF-7i
	for qemu-devel@nongnu.org; Tue, 31 May 2016 04:50:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b7fNd-0008IK-8C
	for qemu-devel@nongnu.org; Tue, 31 May 2016 04:50:33 -0400
Received: from mail-db3on0147.outbound.protection.outlook.com
	([157.55.234.147]:17338
	helo=emea01-db3-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@virtuozzo.com>) id 1b7fNc-0008IE-Cg
	for qemu-devel@nongnu.org; Tue, 31 May 2016 04:50:29 -0400
References: <1463473231-491-1-git-send-email-den@openvz.org>
	<1463473231-491-4-git-send-email-den@openvz.org>
	<573E4B90.7090702@redhat.com>
From: "Denis V. Lunev" <den@openvz.org>
Message-ID: <574D504D.1010906@openvz.org>
Date: Tue, 31 May 2016 11:50:21 +0300
MIME-Version: 1.0
In-Reply-To: <573E4B90.7090702@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 05/20/2016 02:26 AM, Eric Blake wrote:
> On 05/17/2016 02:20 AM, Denis V. Lunev wrote:
>> Pls note, trace_init_backends() must be called in the final process, i.e.
> s/Pls/Please/
>
>> after daemonization. This is necessary to keep tracing thread in the
>> proper process.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> ---
>>   qemu-nbd.c | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
> Same comments as on 2/3 - missing documentation - this time, it is the
> man page that is incomplete.
>
>> @@ -87,6 +89,7 @@ static void usage(const char *name)
>>   "General purpose options:\n"
>>   "  --object type,id=ID,...   define an object such as 'secret' for providing\n"
>>   "                            passwords and/or encryption keys\n"
>> +"  -T, --trace FILE          enable trace events listed in the given file\n"
> Insufficient, compared to how qemu's help text reads.
>
> But overall a cool concept.  Are there any plans to convert some of the
> TRACE() debugging printfs in nbd/* into actual trace points?
>
hmm, interesting. Will think on this.