* [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some
@ 2016-05-31 8:31 Markus Armbruster
2016-05-31 8:50 ` Marcel Apfelbaum
2016-06-13 9:03 ` Markus Armbruster
0 siblings, 2 replies; 5+ messages in thread
From: Markus Armbruster @ 2016-05-31 8:31 UTC (permalink / raw)
To: qemu-devel, pbonzini
We print a few fatal error messages to stdout instead of stderr.
Reproducer:
$ qemu-system-x86_64 -g 1024x768
Option g not supported for this target
$ qemu-system-x86_64 -g 1024x768 >/dev/null
Fix by printing them with error_report(). This also improves the messages.
The above one becomes
qemu-system-x86_64: -g 1024x768: Option not supported for this target
Reported-by: Tobi {github.com/tobimensch}
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
vl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 18d1423..7800b31 100644
--- a/vl.c
+++ b/vl.c
@@ -3075,7 +3075,7 @@ int main(int argc, char **argv, char **envp)
popt = lookup_opt(argc, argv, &optarg, &optind);
if (!(popt->arch_mask & arch_type)) {
- printf("Option %s not supported for this target\n", popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
switch(popt->index) {
@@ -3849,21 +3849,21 @@ int main(int argc, char **argv, char **envp)
break;
case QEMU_OPTION_xen_domid:
if (!(xen_available())) {
- printf("Option %s not supported for this target\n", popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
xen_domid = atoi(optarg);
break;
case QEMU_OPTION_xen_create:
if (!(xen_available())) {
- printf("Option %s not supported for this target\n", popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
xen_mode = XEN_CREATE;
break;
case QEMU_OPTION_xen_attach:
if (!(xen_available())) {
- printf("Option %s not supported for this target\n", popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
xen_mode = XEN_ATTACH;
--
2.5.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some
2016-05-31 8:31 [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some Markus Armbruster
@ 2016-05-31 8:50 ` Marcel Apfelbaum
2016-06-13 9:03 ` Markus Armbruster
1 sibling, 0 replies; 5+ messages in thread
From: Marcel Apfelbaum @ 2016-05-31 8:50 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel, pbonzini
On 05/31/2016 11:31 AM, Markus Armbruster wrote:
> We print a few fatal error messages to stdout instead of stderr.
> Reproducer:
>
> $ qemu-system-x86_64 -g 1024x768
> Option g not supported for this target
> $ qemu-system-x86_64 -g 1024x768 >/dev/null
>
> Fix by printing them with error_report(). This also improves the messages.
> The above one becomes
>
> qemu-system-x86_64: -g 1024x768: Option not supported for this target
>
> Reported-by: Tobi {github.com/tobimensch}
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> vl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 18d1423..7800b31 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3075,7 +3075,7 @@ int main(int argc, char **argv, char **envp)
>
> popt = lookup_opt(argc, argv, &optarg, &optind);
> if (!(popt->arch_mask & arch_type)) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> switch(popt->index) {
> @@ -3849,21 +3849,21 @@ int main(int argc, char **argv, char **envp)
> break;
> case QEMU_OPTION_xen_domid:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_domid = atoi(optarg);
> break;
> case QEMU_OPTION_xen_create:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_mode = XEN_CREATE;
> break;
> case QEMU_OPTION_xen_attach:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_mode = XEN_ATTACH;
>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Thanks,
Marcel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some
2016-05-31 8:31 [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some Markus Armbruster
2016-05-31 8:50 ` Marcel Apfelbaum
@ 2016-06-13 9:03 ` Markus Armbruster
2016-06-13 9:14 ` Paolo Bonzini
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2016-06-13 9:03 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini
Paolo, will you pick this up, or do you want me to take it through my
(currently empty) error-next branch?
Markus Armbruster <armbru@redhat.com> writes:
> We print a few fatal error messages to stdout instead of stderr.
> Reproducer:
>
> $ qemu-system-x86_64 -g 1024x768
> Option g not supported for this target
> $ qemu-system-x86_64 -g 1024x768 >/dev/null
>
> Fix by printing them with error_report(). This also improves the messages.
> The above one becomes
>
> qemu-system-x86_64: -g 1024x768: Option not supported for this target
>
> Reported-by: Tobi {github.com/tobimensch}
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> vl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 18d1423..7800b31 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3075,7 +3075,7 @@ int main(int argc, char **argv, char **envp)
>
> popt = lookup_opt(argc, argv, &optarg, &optind);
> if (!(popt->arch_mask & arch_type)) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> switch(popt->index) {
> @@ -3849,21 +3849,21 @@ int main(int argc, char **argv, char **envp)
> break;
> case QEMU_OPTION_xen_domid:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_domid = atoi(optarg);
> break;
> case QEMU_OPTION_xen_create:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_mode = XEN_CREATE;
> break;
> case QEMU_OPTION_xen_attach:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n", popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_mode = XEN_ATTACH;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some
2016-06-13 9:03 ` Markus Armbruster
@ 2016-06-13 9:14 ` Paolo Bonzini
2016-06-20 15:03 ` Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2016-06-13 9:14 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
On 13/06/2016 11:03, Markus Armbruster wrote:
> Paolo, will you pick this up, or do you want me to take it through my
> (currently empty) error-next branch?
I can pick it up.
Paolo
> Markus Armbruster <armbru@redhat.com> writes:
>
>> We print a few fatal error messages to stdout instead of stderr.
>> Reproducer:
>>
>> $ qemu-system-x86_64 -g 1024x768
>> Option g not supported for this target
>> $ qemu-system-x86_64 -g 1024x768 >/dev/null
>>
>> Fix by printing them with error_report(). This also improves the messages.
>> The above one becomes
>>
>> qemu-system-x86_64: -g 1024x768: Option not supported for this target
>>
>> Reported-by: Tobi {github.com/tobimensch}
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> vl.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 18d1423..7800b31 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3075,7 +3075,7 @@ int main(int argc, char **argv, char **envp)
>>
>> popt = lookup_opt(argc, argv, &optarg, &optind);
>> if (!(popt->arch_mask & arch_type)) {
>> - printf("Option %s not supported for this target\n", popt->name);
>> + error_report("Option not supported for this target");
>> exit(1);
>> }
>> switch(popt->index) {
>> @@ -3849,21 +3849,21 @@ int main(int argc, char **argv, char **envp)
>> break;
>> case QEMU_OPTION_xen_domid:
>> if (!(xen_available())) {
>> - printf("Option %s not supported for this target\n", popt->name);
>> + error_report("Option not supported for this target");
>> exit(1);
>> }
>> xen_domid = atoi(optarg);
>> break;
>> case QEMU_OPTION_xen_create:
>> if (!(xen_available())) {
>> - printf("Option %s not supported for this target\n", popt->name);
>> + error_report("Option not supported for this target");
>> exit(1);
>> }
>> xen_mode = XEN_CREATE;
>> break;
>> case QEMU_OPTION_xen_attach:
>> if (!(xen_available())) {
>> - printf("Option %s not supported for this target\n", popt->name);
>> + error_report("Option not supported for this target");
>> exit(1);
>> }
>> xen_mode = XEN_ATTACH;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some
2016-06-13 9:14 ` Paolo Bonzini
@ 2016-06-20 15:03 ` Markus Armbruster
0 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2016-06-20 15:03 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 13/06/2016 11:03, Markus Armbruster wrote:
>> Paolo, will you pick this up, or do you want me to take it through my
>> (currently empty) error-next branch?
>
> I can pick it up.
Since other error-related patches have since accumulated, I posted a
pull request for all of them. Thanks anyway!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-20 15:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31 8:31 [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some Markus Armbruster
2016-05-31 8:50 ` Marcel Apfelbaum
2016-06-13 9:03 ` Markus Armbruster
2016-06-13 9:14 ` Paolo Bonzini
2016-06-20 15:03 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).