From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7j7b-0004i6-7o for qemu-devel@nongnu.org; Tue, 31 May 2016 08:50:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7j7W-000092-KO for qemu-devel@nongnu.org; Tue, 31 May 2016 08:50:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7j7W-00008M-Bk for qemu-devel@nongnu.org; Tue, 31 May 2016 08:50:06 -0400 References: <1464689222-1513-1-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <574D887C.7010806@redhat.com> Date: Tue, 31 May 2016 06:50:04 -0600 MIME-Version: 1.0 In-Reply-To: <1464689222-1513-1-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LCvNmvsbbkj6e7FRIitJIxhX0WfvmAUHr" Subject: Re: [Qemu-devel] [PATCH 4/4] trace: enable trace events in qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LCvNmvsbbkj6e7FRIitJIxhX0WfvmAUHr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/31/2016 04:07 AM, Denis V. Lunev wrote: > The command will work this way: > qemu-img create --trace qcow2* -f qcow2 1.img 64G >=20 > Signed-off-by: Denis V. Lunev > Suggested by: Daniel P. Berrange > CC: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > qemu-img.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++- > 1 file changed, 96 insertions(+), 1 deletion(-) Missing man page additions. > @@ -155,7 +157,12 @@ static void QEMU_NORETURN help(void) > "Parameters to compare subcommand:\n" > " '-f' first image format\n" > " '-F' second image format\n" > - " '-s' run in Strict mode - fail on different image size o= r sector allocation\n"; > + " '-s' run in Strict mode - fail on different image size o= r sector allocation\n" > + "\n" > + "General purpose options:\n" > + " -R, --trace [[enable=3D]][,events=3D][,fi= le=3D]\n" > + " specify tracing options\n" > + " see qemu(1) man page for full description\n"; Why -R? Because -T is already in use by rebase and compare? I'd almost rather have _just_ --trace with no short option, than to pick yet another letter, but you might want to wait for other opinions first. I'd list general parameters before sub-command parameters. I'd also update the synopsis: qemu-img [general options] command [command options] --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LCvNmvsbbkj6e7FRIitJIxhX0WfvmAUHr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXTYh8AAoJEKeha0olJ0NqLYIH/RmvhdSL0PYoATlhofcgIOKS tSBTZo87YhVb4XykW3nTadRgEEcPCEh+Z+S/duS9AkTiyRjxt4uFhrsNu92wqGAw IR7NsL+UO6+yDiykd7e433EcVh+dY3uqPbDaiRgDXiEFykTnFdAzgaHp8kRNgD+8 y1PWh0aN++atd0zs9a0vyhDqjR9xWnz5pkrwi026rFeREFvyxTUcUCKBWvtH46+W wyqBZ42ud0KaVT5WPUwf+4G9zqCBWtCgLEpL/byiIR02yQKWvpiI5bn8HnmPMT6V IYi7eS6Lys91c9x1x+0YAbFct5WO1zkPbUtz3m8Nq8735+8MzwJofusHCCU9p68= =DF1O -----END PGP SIGNATURE----- --LCvNmvsbbkj6e7FRIitJIxhX0WfvmAUHr--