From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7ohA-0001Du-4S for qemu-devel@nongnu.org; Tue, 31 May 2016 14:47:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7oh5-0003Vq-22 for qemu-devel@nongnu.org; Tue, 31 May 2016 14:47:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7oh4-0003Vj-Q1 for qemu-devel@nongnu.org; Tue, 31 May 2016 14:47:10 -0400 References: <1460346962-10420-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1460346962-10420-2-git-send-email-xiecl.fnst@cn.fujitsu.com> <20160527111821.GI1184@perard.uk.xensource.com> From: Eric Blake Message-ID: <574DDC2D.4000108@redhat.com> Date: Tue, 31 May 2016 12:47:09 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="315UMRV5T9f3booO3qAtCgcmt7HgtbpjW" Subject: Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , Anthony PERARD Cc: Changlong Xie , zhanghailiang , Stefano Stabellini , Juan Quintela , qemu devel , Markus Armbruster , Amit Shah , "Dr. David Alan Gilbert" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --315UMRV5T9f3booO3qAtCgcmt7HgtbpjW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/30/2016 09:17 AM, Stefano Stabellini wrote: > On Fri, 27 May 2016, Anthony PERARD wrote: >> On Mon, Apr 11, 2016 at 11:56:02AM +0800, Changlong Xie wrote: >>> From: Wen Congyang >>> >>> Introduce a "xen-load-devices-state" QAPI command that can be used to= >>> load the state of all devices, but not the RAM or the block devices o= f >>> the VM. >>> >>> We only have hmp commands savevm/loadvm, and qmp commands >>> xen-save-devices-state. >>> >>> We use this new command for COLO: >>> 1. suspend both primary vm and secondary vm >>> 2. sync the state >>> 3. resume both primary vm and secondary vm >>> >>> In such case, we need to update all devices' state in any time. >>> >>> Signed-off-by: Wen Congyang >>> Signed-off-by: Changlong Xie >> >> This patch looks good to me. >> >> Reviewed-by: Anthony PERARD >=20 > It would be nicer (and less problematic) to load the state from a file > descriptor, but given that we still saving the state to file, it would > be unfair to ask to use file descriptors here. If you use qemu_open(), then you can pass the magic "/dev/fdset/1" notation to use a file descriptor previously added to an fdset. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --315UMRV5T9f3booO3qAtCgcmt7HgtbpjW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXTdwtAAoJEKeha0olJ0NqfSkH/3ebACU4PgL8c59m8mxyavwG eDwgp3KdotHpgDezwdgIpDg5su6tbV+gAVzBJqhMy0JHztqwJxI6uwwquZxq9xO1 T7jdKIK+ok76vEUV1bzMx2Od42YTcdCLU+qPV+EmaCZKgx3ad2A47xr9OjNWkuO+ tmijPXnIzgsf6vld/Kr7wd5DBwj4EAt0WWieeyBSWp0aW1OEqZl3P0IaHiP/mrWR j7+xsUKJAjmBye/ZQEv6FtJZN8LpDczffbF82ib0QIQ20xMueW+phjP8dmPsm03b xzGd97iXNUQOhdOC2FV32a8XNEHQjaFDjIQFk9lYwa1b3VGi13aV5UPUr+BqZ/E= =pnM4 -----END PGP SIGNATURE----- --315UMRV5T9f3booO3qAtCgcmt7HgtbpjW--