From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7wPa-00077c-C1 for qemu-devel@nongnu.org; Tue, 31 May 2016 23:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7wPU-0000Ce-O4 for qemu-devel@nongnu.org; Tue, 31 May 2016 23:01:37 -0400 Received: from [59.151.112.132] (port=37467 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7wPT-0000Ax-Vw for qemu-devel@nongnu.org; Tue, 31 May 2016 23:01:32 -0400 References: <1464062689-32156-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Cao jin Message-ID: <574E5129.7050909@cn.fujitsu.com> Date: Wed, 1 Jun 2016 11:06:17 +0800 MIME-Version: 1.0 In-Reply-To: <1464062689-32156-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 00/11] Add param Error ** for msi_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Jason Wang , Markus Armbruster , Marcel Apfelbaum , Alex Williamson , Hannes Reinecke , Dmitry Fleytman , Paolo Bonzini , John Snow , Gerd Hoffmann ping? On 05/24/2016 12:04 PM, Cao jin wrote: > v6 changelog: > 1. make "assert ENOSPC" the 1st one in the series, and remove ENOSPC line > of comments of msi_init(). also fix to other minor comments. > 2. Because semantics changes, add hint message for devices who have msi/msix > property, to help old machine user to know what should do > 3. update pci_bridge_dev hehaviour, because it has non-msi variant, but it can > never fall back to INTx before the patch. make it behaviour like others > 4. mptsas: forget to assign s->msi_in_use before, now make it. > > About test: Only compiled every patch. > > cc: Gerd Hoffmann > cc: John Snow > cc: Dmitry Fleytman > cc: Jason Wang > cc: Michael S. Tsirkin > cc: Hannes Reinecke > cc: Paolo Bonzini > cc: Alex Williamson > cc: Markus Armbruster > cc: Marcel Apfelbaum > > Cao jin (11): > pci core: assert ENOSPC when add capability > fix some coding style problems > change pvscsi_init_msi() type to void > megasas: Fix > mptsas: change .realize function name > usb xhci: change msi/msix property type > intel-hda: change msi property type > mptsas: change msi property type > megasas: change msi/msix property type > pci bridge dev: change msi property type > pci: Convert msi_init() to Error and fix callers to check it > > hw/audio/intel-hda.c | 23 ++++++++++++++---- > hw/ide/ich.c | 17 +++++++++----- > hw/net/vmxnet3.c | 44 ++++++++++++++-------------------- > hw/pci-bridge/ioh3420.c | 12 ++++++++-- > hw/pci-bridge/pci_bridge_dev.c | 31 +++++++++++++++++------- > hw/pci-bridge/xio3130_downstream.c | 11 +++++++-- > hw/pci-bridge/xio3130_upstream.c | 8 ++++++- > hw/pci/msi.c | 25 ++++++++++++++++++-- > hw/pci/pci.c | 6 ++--- > hw/scsi/megasas.c | 48 +++++++++++++++++++++----------------- > hw/scsi/mptsas.c | 32 ++++++++++++++++++------- > hw/scsi/mptsas.h | 3 ++- > hw/scsi/vmw_pvscsi.c | 10 ++++---- > hw/usb/hcd-xhci.c | 33 +++++++++++++++++++------- > hw/vfio/pci.c | 7 ++++-- > include/hw/pci/msi.h | 3 ++- > 16 files changed, 209 insertions(+), 104 deletions(-) > -- Yours Sincerely, Cao jin