qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au,
	imammedo@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH v0 0/2] Increase max memslots to 512 for PowerPC
Date: Wed, 1 Jun 2016 12:18:22 +0200	[thread overview]
Message-ID: <574EB66E.1040805@redhat.com> (raw)
In-Reply-To: <201606010952.u519n6ri025307@mx0a-001b2d01.pphosted.com>

On 01.06.2016 11:51, Bharata B Rao wrote:
> Recently the number of memory slots supported by KVM for PowerPC was changed
> from 32 to 512. QEMU was restricting the user specifiable hot-pluggable memory
> slots to 32. This patchset changes that to 512.
> 
> This allows more number of slots to be available for memory hotplugging.

It's certainly a good idea to increase the number of slots for
hot-pluggable memory. But should we really increase it to the full
maximum of 512 slots? The in-kernel slots are shared with other memory
regions, too, e.g. the memory slots for PCI cards. So if you allow the
users to plug all slots with DIMMs, they certainly will run into
problems there again later.

I think x86 is also using 256 DIMM slots only on purpose (see
https://lkml.org/lkml/2014/11/14/328 for example), so we should maybe
also limit the max. number of DIMM slots on spapr to
kvm_get_max_memslots() divided by two ?

 Thomas

       reply	other threads:[~2016-06-01 10:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201606010952.u519n6ri025307@mx0a-001b2d01.pphosted.com>
2016-06-01 10:18 ` Thomas Huth [this message]
2016-06-02  0:42   ` [Qemu-devel] [RFC PATCH v0 0/2] Increase max memslots to 512 for PowerPC David Gibson
2016-06-02  4:39     ` Bharata B Rao
2016-06-02  7:03       ` Thomas Huth
2016-06-02 14:07         ` Bharata B Rao
2016-06-02 17:17           ` Thomas Huth
2016-06-03  1:14           ` David Gibson
2016-06-01  9:51 Bharata B Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574EB66E.1040805@redhat.com \
    --to=thuth@redhat.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).