From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8F9T-0000jD-VC for qemu-devel@nongnu.org; Wed, 01 Jun 2016 19:02:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8F9R-0002Lp-Ie for qemu-devel@nongnu.org; Wed, 01 Jun 2016 19:02:14 -0400 References: <1463006384-7734-1-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <574F696D.3030109@redhat.com> Date: Wed, 1 Jun 2016 17:02:05 -0600 MIME-Version: 1.0 In-Reply-To: <1463006384-7734-1-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d3eH12NDNnSFGGdPRlNWpjfcSRDkkFfdJ" Subject: Re: [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, alex@alex.org.uk, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d3eH12NDNnSFGGdPRlNWpjfcSRDkkFfdJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ping On 05/11/2016 04:39 PM, Eric Blake wrote: > Fix several corner-case bugs in our implementation of the NBD > protocol, both as client and as server. >=20 > Depends on Kevin's block-next branch: > git://repo.or.cz/qemu/kevin.git block-next >=20 > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git nbd-flags-v4 >=20 > Broken out of a larger v3 series[1], for easier review. There > are still some places where we aren't quite compliant (for example, > the protocol recommends that the client send NBD_OPT_ABORT before > dropping the connection after receiving a valid server response it > didn't like but which did not violate protocol), but later series > will tackle that. >=20 > [1] https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03526.html= >=20 > Changes in v4: rebase to latest block-next >=20 > 001/11:[----] [--] 'nbd: Use BDRV_REQ_FUA for better FUA where supporte= d' > 002/11:[0004] [FC] 'nbd: More debug typo fixes, use correct formats' > 003/11:[----] [--] 'nbd: Quit server after any write error' > 004/11:[----] [--] 'nbd: Improve server handling of bogus commands' > 005/11:[----] [--] 'nbd: Reject unknown request flags' > 006/11:[----] [--] 'nbd: Group all Linux-specific ioctl code in one pla= ce' > 007/11:[----] [--] 'nbd: Clean up ioctl handling of qemu-nbd -c' > 008/11:[----] [-C] 'nbd: Limit nbdflags to 16 bits' > 009/11:[----] [--] 'nbd: Add qemu-nbd -D for human-readable description= ' > 010/11:[----] [--] 'nbd: Detect servers that send unexpected error valu= es' > 011/11:[----] [--] 'nbd: Avoid magic number for NBD max name size' >=20 > Eric Blake (11): > nbd: Use BDRV_REQ_FUA for better FUA where supported > nbd: More debug typo fixes, use correct formats > nbd: Quit server after any write error > nbd: Improve server handling of bogus commands > nbd: Reject unknown request flags > nbd: Group all Linux-specific ioctl code in one place > nbd: Clean up ioctl handling of qemu-nbd -c > nbd: Limit nbdflags to 16 bits > nbd: Add qemu-nbd -D for human-readable description > nbd: Detect servers that send unexpected error values > nbd: Avoid magic number for NBD max name size >=20 > block/nbd-client.h | 2 +- > include/block/nbd.h | 13 ++- > nbd/nbd-internal.h | 5 +- > nbd/client.c | 106 ++++++++++++++++--------- > nbd/server.c | 224 +++++++++++++++++++++++++++++++-------------= -------- > qemu-nbd.c | 16 +++- > qemu-nbd.texi | 5 +- > 7 files changed, 233 insertions(+), 138 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --d3eH12NDNnSFGGdPRlNWpjfcSRDkkFfdJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXT2ltAAoJEKeha0olJ0NqMooIALC8eWl2FBrtaS1Vl0icmxmB EbPmmlzDQyuTESRNlpdM8sxKcqQtJV4Zccd3DY6gIwvYb72qCMoGz65ihCP63xln a9S7FhLgzjn+al2VH7yv8so+dXc/YhDKqYMwaypwtFTIJenlQRK0zGOBb3PtGNYp DksvT3JGM/TJe16U+q3+Fn5o2GoQJ12eSBD5fmqeWcggLZt28dvo0ZsPcWjJfLDS BfwpXjOUbf+zEgCN0TsO/oozsrnkNNuN7FrR4e/ysvVGTLx7/HfCnK9xEIaRBhf/ oqiaZZMG4SuPajb1mBIu0r0KT2lrG33d1NKPyUAMVdkma5eHAkHcVXtXYlYqcH8= =VJAr -----END PGP SIGNATURE----- --d3eH12NDNnSFGGdPRlNWpjfcSRDkkFfdJ--