Re: [PATCH v2 3/5] migration: Add .save_prepare() handler to struct SaveVMHandlers

["Cédric Le Goater" <clg@redhat.com>]

On 9/6/23 16:11, Avihai Horon wrote:
> 
> On 05/09/2023 19:13, Cédric Le Goater wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 9/1/23 17:49, Peter Xu wrote:
>>> On Thu, Aug 31, 2023 at 03:57:00PM +0300, Avihai Horon wrote:
>>>> Add a new .save_prepare() handler to struct SaveVMHandlers. This handler
>>>> is called early, even before migration starts, and can be used by
>>>> devices to perform early checks.
>>>>
>>>> Suggested-by: Peter Xu <peterx@redhat.com>
>>>> Signed-off-by: Avihai Horon <avihaih@nvidia.com>
>>>
>>> Shouldn't be hard to unify the two call sites for qmp migrate and save
>>> snapshot, but we can leave that for later:
>>
>> yes. It could be called from migrate_init() with minor changes.
>>
>> We could probably move :
>>
>>     memset(&mig_stats, 0, sizeof(mig_stats));
>>     memset(&compression_counters, 0, sizeof(compression_counters));
>>     migration_reset_vfio_bytes_transferred();
>>
>> under migrate_init() also.
> 
> I will send v3 with the above changes shortly.

Good timing. I was going to start working on downstream.

Thanks !

C.