From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1b8PwB-0003uu-L9
	for qemu-devel@nongnu.org; Thu, 02 Jun 2016 06:33:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1b8Pw7-0001kM-Dz
	for qemu-devel@nongnu.org; Thu, 02 Jun 2016 06:33:14 -0400
Received: from [59.151.112.132] (port=28085 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1b8Pw6-0001jq-NF
	for qemu-devel@nongnu.org; Thu, 02 Jun 2016 06:33:11 -0400
Message-ID: <57500C56.5070700@cn.fujitsu.com>
Date: Thu, 2 Jun 2016 18:37:10 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1460346962-10420-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1460346962-10420-2-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<20160527155854.GF4456@grmbl.mre> <20160601172300.GD2310@work-vm>
	<alpine.DEB.2.10.1606021101070.16603@sstabellini-ThinkPad-X260>
	<alpine.DEB.2.10.1606021112510.16603@sstabellini-ThinkPad-X260>
	<20160602101643.GA4085@work-vm>
In-Reply-To: <20160602101643.GA4085@work-vm>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 1/1] Introduce "xen-load-devices-state"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Juan Quintela <quintela@redhat.com>, qemu devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Anthony PERARD <anthony.perard@citrix.com>, Amit Shah <amit.shah@redhat.com>

On 06/02/2016 06:16 PM, Dr. David Alan Gilbert wrote:
> * Stefano Stabellini (sstabellini@kernel.org) wrote:
>> On Thu, 2 Jun 2016, Stefano Stabellini wrote:
>>> On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote:
>>>> * Amit Shah (amit.shah@redhat.com) wrote:
>>>>> Dave, can you take a look?
>>>>
>>>> Yes, I think I'm happy with it;
>>>>
>>>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>>>
>>>> I think people might try interesting non-Xen things with it; for
>>>> example I think if you backed QEMU's main RAM by a /tmp file
>>>> perhaps you could start a guest up even under KVM just
>>>> by loading the devices.
>>>
>>> I added this patch to the Xen queue.
>>
>> I spoke too quickly. I get:
>>
>> /local/qemu/migration/savevm.c: In function 'qmp_xen_load_devices_state':
>> /local/qemu/migration/savevm.c:2089:5: error: implicit declaration of function 'qemu_fopen' [-Werror=implicit-function-declaration]
>> /local/qemu/migration/savevm.c:2089:5: error: nested extern declaration of 'qemu_fopen' [-Werror=nested-externs]
>> /local/qemu/migration/savevm.c:2089:7: error: assignment makes pointer from integer without a cast [-Werror]
>
> Ah, yes, your problem is that Dan's crypto changes have probably just removed that;
> see qmp_xen_save_devices_state and 8925839f  that changed it to use the new qio_channel_file_new_path.
>

Yes, i just send another patchset.

> Dave
>
>>    CC    i386-softmmu/hw/display/virtio-vga.o
>> cc1: all warnings being treated as errors
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
>
> .
>