qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] docker: Fix git-archive for submodules
Date: Fri, 3 Jun 2016 17:22:27 +0800	[thread overview]
Message-ID: <57514C53.90304@redhat.com> (raw)
In-Reply-To: <1464943364-32199-1-git-send-email-famz@redhat.com>



On 2016年06月03日 16:42, Fam Zheng wrote:
> If dtc or pixman submodule is initialized, "git archive" in the subshell
> gets a relative filename against $(SRC_PATH), while we have already
> cd'ed into the submodule directory.
>
> Prefix it with $(CURDIR), which is the full path to the working
> directory.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   tests/docker/Makefile.include | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 2fd2ca3..3788cd8 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -29,7 +29,7 @@ make-archive-maybe = $(if $(wildcard $1/*), \
>   
>   CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.$$$$)
>   # Makes the definition constant after the first expansion
> -DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY)
> +DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := $(CURDIR)/docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY)
>   
>   $(DOCKER_SRC_COPY):
>   	@mkdir $@

Tested-by: Jason Wang <jasowang@redhat.com>

  reply	other threads:[~2016-06-03  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  8:42 [Qemu-devel] [PATCH] docker: Fix git-archive for submodules Fam Zheng
2016-06-03  9:22 ` Jason Wang [this message]
2016-06-06 13:43 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57514C53.90304@redhat.com \
    --to=jasowang@redhat.com \
    --cc=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).