From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56293)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1b8qNR-0002gv-8t
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 10:47:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1b8qNP-0007R4-5f
	for qemu-devel@nongnu.org; Fri, 03 Jun 2016 10:47:08 -0400
References: <1464892545-26544-1-git-send-email-den@openvz.org>
	<1464892545-26544-4-git-send-email-den@openvz.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <57519862.5000302@redhat.com>
Date: Fri, 3 Jun 2016 08:46:58 -0600
MIME-Version: 1.0
In-Reply-To: <1464892545-26544-4-git-send-email-den@openvz.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="aeMcg77B9khVGhSu0a9ruAO66dISldcvX"
Subject: Re: [Qemu-devel] [PATCH 3/5] trace: enable tracing in qemu-nbd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>, qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--aeMcg77B9khVGhSu0a9ruAO66dISldcvX
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/02/2016 12:35 PM, Denis V. Lunev wrote:
> Please note, trace_init_backends() must be called in the final process,=

> i.e. after daemonization. This is necessary to keep tracing thread in
> the proper process.
>=20
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---
>  qemu-nbd.c    | 18 +++++++++++++++++-
>  qemu-nbd.texi | 28 ++++++++++++++++++++++++++++
>  2 files changed, 45 insertions(+), 1 deletion(-)
>=20

> +"  --trace [[enable=3D]<pattern>][,events=3D<file>][,file=3D<file>]\n"=

> +"                            specify tracing options\n"

> +++ b/qemu-nbd.texi
> @@ -92,6 +92,34 @@ Display extra debugging information
>  Display this help and exit
>  @item -V, --version
>  Display version information and exit
> +@item -T, --trace [events=3D@var{file}][,file=3D@var{file}]

Why do these two descriptions differ?

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--aeMcg77B9khVGhSu0a9ruAO66dISldcvX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJXUZhiAAoJEKeha0olJ0NqaIQH/0xIghm70HR4dahHTKFWe7bW
TKfntfVZkmSs7YD9eaK3XAx3SkI5PH9abjrkxxJ1HtHE2f3m0tPZT5OtQ/mk27rx
Ks+lfcE1uqQdo0cfi7cTvQM0yt4EZqrgzjackyhTTOpE+eSkrMDdYCVyO6ymAfEk
64PuY5FVkqw8itddQ9gQsyy4pK80Vi1skGmQsmkxlPWnyvcbUQh6v7P17sV2tAbm
5+wWEAOwU8tlOqKLyuGev38rzd2bbAU2fat74AKHHcqf/QbhEzPr0yjm/3BZ0ium
treOZnXH/yRpcftaHaxcErxvVtUCpNGHpqXhhF2D4L2CoZRXdb+GIk/ObWae0IY=
=NdZs
-----END PGP SIGNATURE-----

--aeMcg77B9khVGhSu0a9ruAO66dISldcvX--