From: "Denis V. Lunev" <den@openvz.org>
To: Eric Blake <eblake@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/5] trace: enable tracing in qemu-nbd
Date: Fri, 3 Jun 2016 17:48:44 +0300 [thread overview]
Message-ID: <575198CC.3070007@openvz.org> (raw)
In-Reply-To: <57519862.5000302@redhat.com>
On 06/03/2016 05:46 PM, Eric Blake wrote:
> On 06/02/2016 12:35 PM, Denis V. Lunev wrote:
>> Please note, trace_init_backends() must be called in the final process,
>> i.e. after daemonization. This is necessary to keep tracing thread in
>> the proper process.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Eric Blake <eblake@redhat.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> CC: Kevin Wolf <kwolf@redhat.com>
>> ---
>> qemu-nbd.c | 18 +++++++++++++++++-
>> qemu-nbd.texi | 28 ++++++++++++++++++++++++++++
>> 2 files changed, 45 insertions(+), 1 deletion(-)
>>
>> +" --trace [[enable=]<pattern>][,events=<file>][,file=<file>]\n"
>> +" specify tracing options\n"
>> +++ b/qemu-nbd.texi
>> @@ -92,6 +92,34 @@ Display extra debugging information
>> Display this help and exit
>> @item -V, --version
>> Display version information and exit
>> +@item -T, --trace [events=@var{file}][,file=@var{file}]
> Why do these two descriptions differ?
>
my fault. I have changed description several times. Man is correct
next prev parent reply other threads:[~2016-06-03 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 18:35 [Qemu-devel] [PATCH v3 0/5] trace: enable tracing in qemu-io/qemu-nbd/qemu-img Denis V. Lunev
2016-06-02 18:35 ` [Qemu-devel] [PATCH 1/5] trace: move qemu_trace_opts to trace/control.c Denis V. Lunev
2016-06-02 18:35 ` [Qemu-devel] [PATCH 2/5] trace: enable tracing in qemu-io Denis V. Lunev
2016-06-02 18:35 ` [Qemu-devel] [PATCH 3/5] trace: enable tracing in qemu-nbd Denis V. Lunev
2016-06-03 14:46 ` Eric Blake
2016-06-03 14:48 ` Denis V. Lunev [this message]
2016-06-02 18:35 ` [Qemu-devel] [PATCH 4/5] qemu-img: move common options parsing before commands processing Denis V. Lunev
2016-06-03 14:50 ` Eric Blake
2016-06-02 18:35 ` [Qemu-devel] [PATCH 5/5] trace: enable tracing in qemu-img Denis V. Lunev
2016-06-03 14:55 ` Eric Blake
2016-06-03 14:58 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575198CC.3070007@openvz.org \
--to=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).