From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8qVT-0007oo-Ur for qemu-devel@nongnu.org; Fri, 03 Jun 2016 10:55:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8qVR-0002Nd-RS for qemu-devel@nongnu.org; Fri, 03 Jun 2016 10:55:26 -0400 References: <1464892545-26544-1-git-send-email-den@openvz.org> <1464892545-26544-6-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <57519A56.1090102@redhat.com> Date: Fri, 3 Jun 2016 08:55:18 -0600 MIME-Version: 1.0 In-Reply-To: <1464892545-26544-6-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lnq2mE44J972j565HPwHHaITXNE2Tbh1P" Subject: Re: [Qemu-devel] [PATCH 5/5] trace: enable tracing in qemu-img List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Lnq2mE44J972j565HPwHHaITXNE2Tbh1P Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/02/2016 12:35 PM, Denis V. Lunev wrote: > The command will work this way: > qemu-img --trace qcow2* create -f qcow2 1.img 64G >=20 > Signed-off-by: Denis V. Lunev > Suggested by: Daniel P. Berrange > CC: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > --- > qemu-img.c | 24 +++++++++++++++++++++--- > qemu-img.texi | 34 +++++++++++++++++++++++++++++++++- > 2 files changed, 54 insertions(+), 4 deletions(-) >=20 > @@ -87,7 +89,7 @@ static void QEMU_NORETURN help(void) > { > const char *help_msg =3D > QEMU_IMG_VERSION > - "usage: qemu-img command [command options]\n" > + "usage: qemu-img [common options] command [command options]= \n" > "QEMU disk image utility\n" This hunk belongs in the previous patch > "\n" > "Command syntax:\n" > @@ -156,10 +158,14 @@ static void QEMU_NORETURN help(void) > " '-f' first image format\n" > " '-F' second image format\n" > " '-s' run in Strict mode - fail on different image size o= r sector allocation\n"; > + const char *help_msg2 =3D > + "Common options:\n" > + " '-T', --trace [[enable=3D]][,events=3D][,= file=3D]\n" > + " specify tracing options\n"; Part of this hunk belongs in the previous patch, along with mention of -h/--help as a common option moved up to this area, and adding mention of -v/--version (once you fix -v to actually work). > +++ b/qemu-img.texi > @@ -1,6 +1,6 @@ > @example > @c man begin SYNOPSIS > -@command{qemu-img} @var{command} [@var{command} @var{options}] > +@command{qemu-img} [@var{common} @var{options}] @var{command} [@var{co= mmand} @var{options}] Again, this hunk belongs in the previous commit. > @c man end > @end example > =20 > @@ -16,6 +16,38 @@ inconsistent state. > =20 > @c man begin OPTIONS > =20 > +Common options: > +@table @option > +@item -T, --trace [events=3D@var{file}][,file=3D@var{file}] As in patch 3, why does this synopsis vary from the --help output? Rather than duplicating the same text in multiple .texi files, should we put the text in a single sub-file then use inclusion to pull it in? That way, if we ever tweak the common option parsing for --trace, updating the one sub-file will update all 3 man pages (qemu, qemu-img, qemu-nbd). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Lnq2mE44J972j565HPwHHaITXNE2Tbh1P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXUZpWAAoJEKeha0olJ0Nqy+0H/0CfdaLVDNNb96e53kRyBgfA 7dnLppY4SnK6BUHmerY2pnBh146iKAY0malqpnkUusm4rv1UB5Kp4gFwqusRk3zq gXEkfwdXjjjyzRyi4GTNocOXvbxDRR/8SfTHM2JPhaClMtzDvpOTCbfEQI/V2BU+ 6osfYseX185HSMTgO5+XDvIj9P0eRvlSZBjOslIJiWo6kEGJ/NZ1tFI31+gvZG2J 9IYittkz0tvXvfNYsLT3hWfETLYzbhOU+kkLK9ogV4l1IsEGJ318Koaz288ApxSs 990SMijac/vqpyV7Silgflv2+G0fIsjzMj6YkrSQAnTUEEwxpD3kEZGbUMz27Ws= =WAqs -----END PGP SIGNATURE----- --Lnq2mE44J972j565HPwHHaITXNE2Tbh1P--