From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8tEA-0001pL-3F for qemu-devel@nongnu.org; Fri, 03 Jun 2016 13:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8tE8-0005Gt-65 for qemu-devel@nongnu.org; Fri, 03 Jun 2016 13:49:45 -0400 References: <1464973388-15821-1-git-send-email-eblake@redhat.com> <1464973388-15821-6-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <5751C32F.3040806@redhat.com> Date: Fri, 3 Jun 2016 11:49:35 -0600 MIME-Version: 1.0 In-Reply-To: <1464973388-15821-6-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Da1jhKWkAGOehh7SXd2q9xPw4LbASCCnJ" Subject: Re: [Qemu-devel] [PATCH 5/5] block: Move request_alignment into BlockLimit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , Stefan Hajnoczi , qemu-block@nongnu.org, Peter Lieven , mreitz@redhat.com, Ronnie Sahlberg , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Da1jhKWkAGOehh7SXd2q9xPw4LbASCCnJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/03/2016 11:03 AM, Eric Blake wrote: > It makes more sense to have ALL block size limit constraints > in the same struct. Improve the documentation while at it. >=20 > Note that bdrv_refresh_limits() has to keep things alive across > a memset() of BlockLimits. >=20 > Signed-off-by: Eric Blake > --- > include/block/block_int.h | 12 ++++++++---- > block.c | 4 ++-- > block/blkdebug.c | 4 ++-- > block/bochs.c | 2 +- > block/cloop.c | 2 +- > block/dmg.c | 2 +- > block/io.c | 12 +++++++----- > block/iscsi.c | 2 +- > block/raw-posix.c | 16 ++++++++-------- > block/raw-win32.c | 6 +++--- > block/vvfat.c | 2 +- > 11 files changed, 35 insertions(+), 29 deletions(-) Something in this patch is causing qemu-iotests 77 to infloop; we may decide it is just easier to drop this patch rather than find all the places where the request_alignment must be preserved across what otherwise zeroes out limits. > +++ b/block/io.c > @@ -71,8 +71,10 @@ void bdrv_refresh_limits(BlockDriverState *bs, Error= **errp) > { > BlockDriver *drv =3D bs->drv; > Error *local_err =3D NULL; > + uint32_t request_alignment =3D bs->bl.request_alignment; >=20 > memset(&bs->bl, 0, sizeof(bs->bl)); > + bs->bl.request_alignment =3D request_alignment; Or put another way, it looks like I missed another case where moving the scope of the variable can impact who is expecting the value to remain unchanged across certain operations. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Da1jhKWkAGOehh7SXd2q9xPw4LbASCCnJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXUcMvAAoJEKeha0olJ0NqGwYH/A9D4PoHZWyxRBBe/fbdKoUn 7bnRQTZrdjOcfnmu2B36rXR3b0rd7tKbjyfypVN9JzZRLL2T8jxCK+4tPiRRAKv7 OtVTcriLaagR2z+kteAhaO8HCNRIjreaTbsL/dCR90M6WKPbvdJjLezjqCCcj4q4 mwMVo4QWOuGmoktiBNuzl5ZkmzetSIzQrLub2cGxwEThuvaaRMCSRvwXCffe8gBf gGl4/wHMJ/iyejimS8IzXeqw3oTzXkDgieHzm2eS+NBigJMs19fohJPu1cYiUC4I iiFE8huzWlbyTjFdLzAha+yHx3hfl0QQ1cLLNtIGyUZxykSZYAwZSQ5qaQbhePQ= =SWN7 -----END PGP SIGNATURE----- --Da1jhKWkAGOehh7SXd2q9xPw4LbASCCnJ--