From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9pvD-0006ye-Oj for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:30:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9pv6-00081y-7O for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:30:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:32984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9pv6-00081t-0Z for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:30:00 -0400 References: <1465200062-13824-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1465200062-13824-13-git-send-email-caoj.fnst@cn.fujitsu.com> From: Hannes Reinecke Message-ID: <57553487.7050700@suse.de> Date: Mon, 6 Jun 2016 10:29:59 +0200 MIME-Version: 1.0 In-Reply-To: <1465200062-13824-13-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v7 12/15] pci: Convert msi_init() to Error and fix callers to check it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org Cc: Gerd Hoffmann , John Snow , Dmitry Fleytman , Jason Wang , "Michael S. Tsirkin" , Paolo Bonzini , Alex Williamson , Markus Armbruster , Marcel Apfelbaum On 06/06/2016 10:00 AM, Cao jin wrote: > msi_init() reports errors with error_report(), which is wrong > when it's used in realize(). >=20 > Fix by converting it to Error. >=20 > Fix its callers to handle failure instead of ignoring it. >=20 > For those callers who don't handle the failure, it might happen: > when user want msi on, but he doesn't get what he want because of > msi_init fails silently. >=20 > cc: Gerd Hoffmann > cc: John Snow > cc: Dmitry Fleytman > cc: Jason Wang > cc: Michael S. Tsirkin > cc: Hannes Reinecke > cc: Paolo Bonzini > cc: Alex Williamson > cc: Markus Armbruster > cc: Marcel Apfelbaum >=20 > Signed-off-by: Cao jin > --- > hw/audio/intel-hda.c | 25 +++++++++++++++++++++---- > hw/ide/ich.c | 15 +++++++++------ > hw/net/vmxnet3.c | 38 +++++++++++++-----------------= -------- > hw/pci-bridge/ioh3420.c | 6 +++++- > hw/pci-bridge/pci_bridge_dev.c | 20 ++++++++++++++++---- > hw/pci-bridge/xio3130_downstream.c | 6 +++++- > hw/pci-bridge/xio3130_upstream.c | 6 +++++- > hw/pci/msi.c | 11 ++++++++--- > hw/scsi/megasas.c | 27 ++++++++++++++++++++++----- > hw/scsi/mptsas.c | 31 ++++++++++++++++++++++++------= - > hw/scsi/vmw_pvscsi.c | 4 +++- > hw/usb/hcd-xhci.c | 23 +++++++++++++++++++---- > hw/vfio/pci.c | 7 +++++-- > include/hw/pci/msi.h | 3 ++- > 14 files changed, 157 insertions(+), 65 deletions(-) >=20 For the megasas parts: Acked-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg)