From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Hannes Reinecke <hare@suse.de>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success
Date: Mon, 6 Jun 2016 17:19:01 +0800 [thread overview]
Message-ID: <57554005.8070902@cn.fujitsu.com> (raw)
In-Reply-To: <57553419.7000801@suse.de>
On 06/06/2016 04:28 PM, Hannes Reinecke wrote:
> On 06/06/2016 10:00 AM, Cao jin wrote:
>> diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
>> index 4ff4d06..d4773e2 100644
>> --- a/hw/scsi/mptsas.c
>> +++ b/hw/scsi/mptsas.c
>> @@ -1286,7 +1286,7 @@ static void mptsas_scsi_realize(PCIDevice *dev, Error **errp)
>> "mptsas-diag", 0x10000);
>>
>> if (s->msi != ON_OFF_AUTO_OFF &&
>> - msi_init(dev, 0, 1, true, false) >= 0) {
>> + msi_init(dev, 0, 1, true, false) > 0) {
I am so sorry I made the mistake...it should be msi_init() == 0
>> /* TODO check for errors */
>> s->msi_in_use = true;
>> }
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-06-06 9:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 8:00 [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init() Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 01/15] pci core: assert ENOSPC when add capability Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 02/15] fix some coding style problems Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 03/15] change pvscsi_init_msi() type to void Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 04/15] megasas: Fix check for msi_init() failure Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 05/15] mptsas: change .realize function name Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 06/15] usb xhci: change msi/msix property type Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 07/15] intel-hda: change msi " Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 08/15] mptsas: " Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 09/15] megasas: change msi/msix " Cao jin
2016-06-06 8:27 ` Hannes Reinecke
2016-06-06 8:43 ` Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 10/15] pci bridge dev: change msi " Cao jin
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success Cao jin
2016-06-06 8:28 ` Hannes Reinecke
2016-06-06 9:19 ` Cao jin [this message]
2016-06-09 15:32 ` Markus Armbruster
2016-06-06 8:00 ` [Qemu-devel] [PATCH v7 12/15] pci: Convert msi_init() to Error and fix callers to check it Cao jin
2016-06-06 8:29 ` Hannes Reinecke
2016-06-06 8:30 ` Cao jin
2016-06-09 15:53 ` Markus Armbruster
2016-06-09 15:54 ` Markus Armbruster
2016-06-06 8:01 ` [Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary megasas_use_msi() Cao jin
2016-06-06 8:31 ` Hannes Reinecke
2016-06-06 8:01 ` [Qemu-devel] [PATCH v7 14/15] mptsas: remove unnecessary internal msi state flag Cao jin
2016-06-06 8:01 ` [Qemu-devel] [PATCH v7 15/15] vmw_pvscsi: " Cao jin
2016-06-09 15:48 ` Markus Armbruster
2016-06-08 10:15 ` [Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init() Cao jin
2016-06-09 15:58 ` Markus Armbruster
2016-06-10 7:34 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57554005.8070902@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=hare@suse.de \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).