From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sergey.fedorov@linaro.org>) id 1b9xXD-0005rn-4N
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 12:37:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sergey.fedorov@linaro.org>) id 1b9xXC-0003aM-2z
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 12:37:51 -0400
Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:33484)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sergey.fedorov@linaro.org>) id 1b9xXB-0003a8-RT
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 12:37:50 -0400
Received: by mail-lf0-x22e.google.com with SMTP id s64so98419172lfe.0
	for <qemu-devel@nongnu.org>; Mon, 06 Jun 2016 09:37:49 -0700 (PDT)
References: <1463494687-25947-1-git-send-email-peter.maydell@linaro.org>
	<1463494687-25947-6-git-send-email-peter.maydell@linaro.org>
From: Sergey Fedorov <sergey.fedorov@linaro.org>
Message-ID: <5755A6DB.4050409@linaro.org>
Date: Mon, 6 Jun 2016 19:37:47 +0300
MIME-Version: 1.0
In-Reply-To: <1463494687-25947-6-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 5/6] target-i386: Add comment about
 do_interrupt_user() next_eip argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Paolo Bonzini <pbonzini@redhat.com>, Riku Voipio <riku.voipio@iki.fi>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>

On 17/05/16 17:18, Peter Maydell wrote:
> Add a comment to do_interrupt_user() along the same lines as the
> existing one for do_interrupt_all() noting that the next_eip
> argument is not used unless is_int is true or intno is EXCP_SYSCALL.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>

> ---
>  target-i386/seg_helper.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c
> index b5f3d72..860f948 100644
> --- a/target-i386/seg_helper.c
> +++ b/target-i386/seg_helper.c
> @@ -1128,7 +1128,11 @@ static void do_interrupt_real(CPUX86State *env, int intno, int is_int,
>  }
>  
>  #if defined(CONFIG_USER_ONLY)
> -/* fake user mode interrupt */
> +/* fake user mode interrupt. is_int is TRUE if coming from the int
> + * instruction. next_eip is the env->eip value AFTER the interrupt
> + * instruction. It is only relevant if is_int is TRUE or if intno
> + * is EXCP_SYSCALL.
> + */
>  static void do_interrupt_user(CPUX86State *env, int intno, int is_int,
>                                int error_code, target_ulong next_eip)
>  {