From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Ben Aitchison <ben@meh.net.nz>,
qemu-stable@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH STABLE 2.5] vnc: fix VNC websockets TLS handshake
Date: Tue, 7 Jun 2016 08:47:08 -0600 [thread overview]
Message-ID: <5756DE6C.1040103@redhat.com> (raw)
In-Reply-To: <1465309053-5784-1-git-send-email-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On 06/07/2016 08:17 AM, Daniel P. Berrange wrote:
> If the VNC websockets TLS handshake blocked, we register a
> callback to continue it after the socket signals data is
> available. Unfortunately we were mistakenly registering
> the wrong method callback, causing us to restart the TLS
> handshake from the begining, which obviously fails.
s/begining/beginning/
>
> Reported-by: Ben Aitchison <ben@meh.net.nz>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> ui/vnc-ws.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> NB this is a stable-2.5 only patch, with no equiv in master
> since the code was totally refactored in 2.6
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-07 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 14:17 [Qemu-devel] [PATCH STABLE 2.5] vnc: fix VNC websockets TLS handshake Daniel P. Berrange
2016-06-07 14:47 ` Eric Blake [this message]
2016-09-14 15:02 ` Daniel P. Berrange
2016-09-20 16:49 ` [Qemu-devel] [Qemu-stable] " Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756DE6C.1040103@redhat.com \
--to=eblake@redhat.com \
--cc=ben@meh.net.nz \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).