From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAIHi-00040s-Me for qemu-devel@nongnu.org; Tue, 07 Jun 2016 10:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAIHe-0004eA-7A for qemu-devel@nongnu.org; Tue, 07 Jun 2016 10:47:14 -0400 References: <1465309053-5784-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <5756DE6C.1040103@redhat.com> Date: Tue, 7 Jun 2016 08:47:08 -0600 MIME-Version: 1.0 In-Reply-To: <1465309053-5784-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6AVBKb4BM41Rbb0keA5mRSFGwLkdamgCl" Subject: Re: [Qemu-devel] [PATCH STABLE 2.5] vnc: fix VNC websockets TLS handshake List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Ben Aitchison , qemu-stable@nongnu.org, Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6AVBKb4BM41Rbb0keA5mRSFGwLkdamgCl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/07/2016 08:17 AM, Daniel P. Berrange wrote: > If the VNC websockets TLS handshake blocked, we register a > callback to continue it after the socket signals data is > available. Unfortunately we were mistakenly registering > the wrong method callback, causing us to restart the TLS > handshake from the begining, which obviously fails. s/begining/beginning/ >=20 > Reported-by: Ben Aitchison > Signed-off-by: Daniel P. Berrange > --- > ui/vnc-ws.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > NB this is a stable-2.5 only patch, with no equiv in master > since the code was totally refactored in 2.6 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6AVBKb4BM41Rbb0keA5mRSFGwLkdamgCl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXVt5sAAoJEKeha0olJ0NqcUQH/iv17zfJPt823c6ramFz+eR+ HIwJmQrG+Z9qv5Qv08T/9o4XRItmEL5Hz2pdXwYgFMgjucPac8XEzNvyw+wEUO7z XIKT0Cob0VecWhx2OQq/kC19C6AJfQM+NwpnXIchAmj8otSn7TLuG+YpixMQ08Bm xSdOLgp3LwVanBI2HAvNCUwkYNXxDdHhNAdUfcjZIu8sWi+AW7dXWMEAv2jHwKCC qctZUhPzPa3eHjw/NlrTJdBcMiKB6D504f2dasHeLcYPl0rj7LODEIP8+ck82NAE +9YY9TMPOV5lFZSPn9Mi84XBJJyhD/9naMPXSbJp7sb/6Nv3oK4gVQq4xNANl8c= =t+SF -----END PGP SIGNATURE----- --6AVBKb4BM41Rbb0keA5mRSFGwLkdamgCl--