From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAILs-0007cb-DZ for qemu-devel@nongnu.org; Tue, 07 Jun 2016 10:51:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAILo-000618-DS for qemu-devel@nongnu.org; Tue, 07 Jun 2016 10:51:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAILo-000613-73 for qemu-devel@nongnu.org; Tue, 07 Jun 2016 10:51:28 -0400 References: <1465309145-6224-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <5756DF6E.1080901@redhat.com> Date: Tue, 7 Jun 2016 08:51:26 -0600 MIME-Version: 1.0 In-Reply-To: <1465309145-6224-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7HRTuVmHuwpKioQ3qTSKaC3KjQ8Q0VgkC" Subject: Re: [Qemu-devel] [PATCH] io: remove mistaken call to object_ref on QTask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Ben Aitchison This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7HRTuVmHuwpKioQ3qTSKaC3KjQ8Q0VgkC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/07/2016 08:19 AM, Daniel P. Berrange wrote: > The QTask struct is just a standalone struct, not a QOM Object, > so calling object_ref() on it is not appropriate. This results > in mangling the 'destroy' field in the QTask struct, causing > the later call to qtask_free() to try to call the function > at address 0x1, with predictably segfault happy results. >=20 > There is in fact no need for ref counting with QTask, as the > call to qtask_abort() or qtask_complete() will automatically > free associated memory. >=20 > This fixes the crash shown in >=20 > https://bugs.launchpad.net/qemu/+bug/1589923 >=20 > Reported-by: Ben Aitchison > Signed-off-by: Daniel P. Berrange > --- > io/channel-websock.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7HRTuVmHuwpKioQ3qTSKaC3KjQ8Q0VgkC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXVt9uAAoJEKeha0olJ0NqvAwIAIs09X1LjrNLaEPUn2kHig+V dacOK6xeHJpbA6i9j1mGm3lh4xqBQDR9nEdsMO8Cdgs7iQihuEdJl4vjWmuWXJMV Y88Sn5CEMDBpQknG7gshsegkD2ff8yE11YDIX639keOaT0vy8WN61UjO4rmscSvy NAEFjEYhqBproEXqKBPWrUtewtR0+hviVAOfJehMopGyEIyVnRy98jkmWrWFFhs9 j6ylqTD5obkm6eUpDKRtva4aWsYyvUjogw5he5Fi/CU8OKYZ/VXNn8YePLWAtwQl gi9IIF3QzRldtUD8+43B8p0w2hHp8QwPFsLRV70Tc3Q3XjL/eqOvrJIsOu1hZnE= =7Q2B -----END PGP SIGNATURE----- --7HRTuVmHuwpKioQ3qTSKaC3KjQ8Q0VgkC--