From: Eric Blake <eblake@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
qemu-devel@nongnu.org, blauwirbel@gmail.com, qemu-arm@nongnu.org,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 02/10] target-i386: cpu: move features logic that requires CPUState to realize time
Date: Tue, 7 Jun 2016 15:07:33 -0600 [thread overview]
Message-ID: <57573795.9050600@redhat.com> (raw)
In-Reply-To: <20160607202544.GF18662@thinpad.lan.raisama.net>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On 06/07/2016 02:25 PM, Eduardo Habkost wrote:
> [...]
>> + /* TODO: convert plus_features & minus_features static vars
>> + * to global properties, once broken host_features is fixed
>> + */
>
> I will rewrite this to:
>
> /*TODO: cpu->host_features inclurrectly overwrites features
Was that supposed to be "incorrectly" or "currently"?
> * set using "feat=on|off". Once we fix this, we can convert
> * plus_features & minus_features to global properties
> * inside x86_cpu_parse_featurestr() too.
> */
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-07 21:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 15:16 [Qemu-devel] [PATCH 00/10] cpus: make "-cpu cpux, features" global properties Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 01/10] target-i386: Remove xlevel & hv-spinlocks option fixups Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 02/10] target-i386: cpu: move features logic that requires CPUState to realize time Igor Mammedov
2016-06-07 20:25 ` Eduardo Habkost
2016-06-07 21:07 ` Eric Blake [this message]
2016-06-07 22:29 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 03/10] target-i386: cpu: move xcc->kvm_required check " Igor Mammedov
2016-06-07 20:23 ` Eduardo Habkost
2016-06-07 20:28 ` Eduardo Habkost
2016-06-09 18:34 ` Eduardo Habkost
2016-06-10 7:15 ` Igor Mammedov
2016-06-10 11:39 ` Eduardo Habkost
2016-06-10 11:48 ` [Qemu-devel] [PATCH] target-i386: Remove assert(kvm_enabled()) from host_x86_cpu_initfn() Eduardo Habkost
2016-06-10 12:40 ` Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 04/10] target-i386: cpu: use cpu_generic_init() in cpu_x86_init() Igor Mammedov
2016-06-07 20:29 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 05/10] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr Igor Mammedov
2016-06-07 20:37 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used Igor Mammedov
2016-06-07 11:44 ` Paolo Bonzini
2016-06-07 12:32 ` Igor Mammedov
2016-06-07 12:36 ` Paolo Bonzini
2016-06-07 12:54 ` Igor Mammedov
2016-06-07 13:00 ` Paolo Bonzini
2016-06-07 13:26 ` Igor Mammedov
2016-06-07 15:17 ` Eduardo Habkost
2016-06-06 15:16 ` [Qemu-devel] [PATCH 07/10] target-sparc: cpu: use sparc_cpu_parse_features() directly Igor Mammedov
2016-06-08 16:30 ` Eduardo Habkost
2016-06-10 11:51 ` Eduardo Habkost
2016-06-10 18:32 ` Mark Cave-Ayland
2016-06-06 15:16 ` [Qemu-devel] [PATCH 08/10] cpu: use CPUClass->parse_features() as convertor to global properties Igor Mammedov
2016-06-08 16:47 ` Eduardo Habkost
2016-06-09 12:38 ` Igor Mammedov
2016-06-09 13:23 ` Eduardo Habkost
2016-06-09 13:40 ` Igor Mammedov
2016-06-06 15:16 ` [Qemu-devel] [PATCH 09/10] arm: virt: parse cpu_model only once Igor Mammedov
2016-06-08 16:55 ` Eduardo Habkost
2016-06-08 17:25 ` Peter Maydell
2016-06-06 15:16 ` [Qemu-devel] [PATCH 10/10] pc: parse cpu features " Igor Mammedov
2016-06-08 17:03 ` Eduardo Habkost
2016-06-09 12:07 ` Igor Mammedov
2016-06-09 13:25 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57573795.9050600@redhat.com \
--to=eblake@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).