From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bASuq-0001bD-8o for qemu-devel@nongnu.org; Tue, 07 Jun 2016 22:08:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bASum-000327-1H for qemu-devel@nongnu.org; Tue, 07 Jun 2016 22:08:19 -0400 References: <5756DE9D.7050603@linaro.org> From: xiaoqiang zhao Message-ID: <57577DDF.9070202@163.com> Date: Wed, 8 Jun 2016 10:07:27 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [Qemu-discuss] -serial option broken in master? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?UTF-8?B?SsOpcsO0bWUgRm9yaXNzaWVy?= Cc: qemu-discuss , QEMU Developers 在 2016年06月08日 05:24, Peter Maydell 写道: > On 7 June 2016 at 15:47, Jérôme Forissier wrote: >> Hi, >> >> I just noticed this error [1] (QEMU master branch): >> >> ../qemu/arm-softmmu/qemu-system-arm -nographic -monitor none -machine >> virt -machine secure=on -cpu cortex-a15 -m 1057 -serial stdio -serial >> file:serial1.log -bios >> /home/travis/optee_repo/build/../out/bios-qemu/bios.bin >> Unexpected error in parse_chr() at hw/core/qdev-properties-system.c:149: >> qemu-system-arm: Property 'pl011.chardev' can't take value 'serial0', >> it's in use >> >> FYI, revert commits e5fabad7ccfd ("char: get rid of >> qemu_char_get_next_serial") and f0d1d2c115df ("hw/char: QOM'ify pl011 >> model"), and the problem disappears. >> >> Should I use a different syntax? > No, it's a bug that we broke this somehow. Xiaoqiang, could you > have a look at this, please? > > thanks > -- PMM Hi, peter: The bug was caught. It is because in vrit.c, create_uart is called twice, in which serial_hds array is hardcoded. I will send a patch to fix this later .